Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

fix(deps): Fix poetry install#273

Closed
malmeloo wants to merge 1 commit into
pacstall:masterfrom
malmeloo:fix/poetry-deps
Closed

fix(deps): Fix poetry install#273
malmeloo wants to merge 1 commit into
pacstall:masterfrom
malmeloo:fix/poetry-deps

Conversation

@malmeloo

Copy link
Copy Markdown
Member

Fixes poetry install by constraining the pyinstaller build dep to python <3.13.

Poetry suggests to fix this by changing the supported Python version to >=3.10,<3.13, but I don't think it's desirable to limit future version support to how quickly Pyinstaller updates.

@Elsie19

Elsie19 commented Feb 19, 2024

Copy link
Copy Markdown
Member

Is this in relation to the recent PR @srd424 made?

@malmeloo

Copy link
Copy Markdown
Member Author

I don't think so? But the issue it fixes can be observed in #267 and #268. This simply doesn't install pyinstaller for >=3.13 because it doesn't indicate support for those versions.

@Elsie19

Elsie19 commented Feb 19, 2024

Copy link
Copy Markdown
Member

@D-Brox I need your opinion as you're the only python guy at the moment.

@srd424

srd424 commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

Someone who actually understands the python ecosystem should probably look at why #271 works some time :) In particular I suspect a proper review of the anyio / httpcore / httpx versions etc. would fix things "properly."

@Elsie19

Elsie19 commented Feb 19, 2024

Copy link
Copy Markdown
Member

True, our main guy @wizard-28 who's in charge of pacup has been gone for a hot minute so pacup has had basically no development since he went.

@malmeloo

Copy link
Copy Markdown
Member Author

I will take a look at it today or tomorrow.

@malmeloo

Copy link
Copy Markdown
Member Author

...or now :-)

That error is a bug in httpx which is fixed in the latest version: encode/httpcore#825

If you merge this PR and then rebase + merge #216, it will be fixed. I just tested it and can confirm it now works on 3.10.

@Elsie19

Elsie19 commented Feb 21, 2024

Copy link
Copy Markdown
Member

@D-Brox you can handle this PR, idk much about python dependencies and stuff like that.

@Elsie19

Elsie19 commented Apr 11, 2024

Copy link
Copy Markdown
Member

Hey so quick update @malmeloo, we've decided, to rewrite pacup in Perl. So we won't have to deal with python issues anymore 😁, along with it being much easier to interface with bash.

@Elsie19 Elsie19 closed this Apr 11, 2024
@malmeloo

Copy link
Copy Markdown
Member Author

Yes I've been lurking in the discord and following along somewhat, nice! I'm sure that's gonna be way nicer than the cursed pacscript parser pacup has now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants