chore: code-style of Leases.remove_expired#539
Draft
lr4d wants to merge 1 commit into
Draft
Conversation
Owner
|
I am a bit preoccupied at the moment, but I would look forward to have a call with you and talk about life, code and all the rest. Maybe you have some time this weekend? |
Contributor
Author
|
I will reach out to you ;)
…-------- Mensaje original --------
El 7/5/24 18:37, Markus Klein ha escrito:
I am a bit preoccupied at the moment, but I would look forward to have a call with you and talk about life, code and all the rest. Maybe you have some time this weekend?
—
Reply to this email directly, [view it on GitHub](#539 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AKS7LPHNHMFQTXX7HOOUNXTZBDKKRAVCNFSM6AAAAABHIQ3PPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGQZTAOBYHE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was a little scared when I saw all these
muts, so I tried to remove at least one.I can't really tell if it's any better than the original code, @pacman82 I'm curious to hear your view.