feat(#96): remove legacy saved-data persistence bypasses - #111
Conversation
Delete orphaned syncEngine.js (replaced by syncCoordinator.js) and its tests. Strip all legacy sync functions from localStore.js — only getCustomSpecies/setCustomSpecies remain for the device-local species path. Remove the lifecycleFlag and its guard branches in DataContext.jsx; the identity-scoped lifecycle is now the single supported read/write path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 35 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 417ae9f9ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| useEffect(() => { | ||
| if (!lifecycleEnabledRef.current) { | ||
| loadedScopeRef.current = scope; | ||
| setDataLoaded(true); | ||
| return; | ||
| } | ||
| let cancelled = false; |
There was a problem hiding this comment.
When VITE_LIFECYCLE_ENABLED=false or localStorage.lifecycle_override is set to false, this effect now unconditionally loads the identity-scoped repository, and triggerSync likewise runs the coordinator. Those settings were introduced specifically as deployment-time and per-browser emergency rollback controls, so deleting their checks makes an unhealthy lifecycle rollout impossible to disable and contradicts the claimed no-behavior-change cleanup. Preserve the gating until the rollback mechanism is deliberately retired.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Summary
Removes legacy persistence code that was superseded by the identity-scoped
LocalRepository(PR #97) and the lifecycle system (PR #109):syncEngine.jsand its test — replaced bySyncCoordinator+LocalRepositorylocalStore.jsdown togetCustomSpecies/setCustomSpeciesonly — all legacy store-factory code gonelifecycleFlag.jsand its test — flag logic absorbed intoDataContextdirectlylocalStore.test.js(now only covers the two remaining functions)No behavioral change. This is pure dead-code removal after the lifecycle rollout in #109.
Closes #96