Implemented the Bitcoin Core Logs feature in the existing Bitcoin Status Logs tab. - #28
Open
R27-pixel wants to merge 14 commits into
Open
Implemented the Bitcoin Core Logs feature in the existing Bitcoin Status Logs tab.#28R27-pixel wants to merge 14 commits into
R27-pixel wants to merge 14 commits into
Conversation
R27-pixel
marked this pull request as draft
June 18, 2026 05:19
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
R27-pixel
marked this pull request as ready for review
July 19, 2026 08:17
There was a problem hiding this comment.
Pull request overview
This PR implements a functional Bitcoin Core Logs viewer inside the existing Bitcoin Status “Logs” tab, including persisted configuration for locating debug.log, background polling/refresh, filtering + scrolling interactions, and accompanying UI snapshot/test updates. It also introduces a Bitcoin Core RPC client to populate “Chain Info” and “Peers” tabs based on the configured bitcoin.conf.
Changes:
- Added Bitcoin Core log path resolution + recent-line snapshot reading, wired into
Apppolling/refresh and the Bitcoin Status UI. - Persisted new settings for Bitcoin Core data directory and explicit log file path, and updated settings UI/status bar behavior + snapshots accordingly.
- Added a Bitcoin Core RPC client and UI rendering for Chain Info + Peers, plus expanded/updated test coverage across modules.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app.rs | Adds Bitcoin chain/log state, background polling, refresh logic, and OSC52 copy support. |
| src/bitcoin_logs.rs | New module for resolving debug.log paths and reading recent log lines/snapshots. |
| src/components/bitcoin_client.rs | New Bitcoin Core JSON-RPC client used to fetch chain info and peer info. |
| src/components/bitcoin_status_view.rs | Replaces placeholder tabs with real Chain Info / Logs / Peers rendering and log input handling. |
| src/components/mod.rs | Exposes the new bitcoin_client module. |
| src/components/p2pool_status_view.rs | Deduplicates live share rows to avoid repeated entries. |
| src/components/settings_view.rs | Adds two new settings fields and updates rendering logic/tests. |
| src/components/status_bar.rs | Adds Bitcoin Logs tab key-hint behavior and adjusts settings-field indexing. |
| src/lib.rs | Exports the new bitcoin_logs module. |
| src/main.rs | Integrates Bitcoin polling/refresh into the main loop and updates explorer handling for new triggers. |
| src/p2poolv2_config.rs | Adds additional branch-coverage tests for dispatch_edit. |
| src/settings.rs | Adds persisted settings fields + tests for Bitcoin Core log/data-dir paths. |
| src/ui.rs | Updates UI snapshot test setup for the logs tab initial state. |
| src/snapshots/pdm__ui__tests__settings_screen_render.snap | Snapshot update for new settings fields. |
| src/snapshots/pdm__ui__tests__bitcoin_status_tab_peers_render.snap | Snapshot update for peers tab rendering prompt. |
| src/snapshots/pdm__ui__tests__bitcoin_status_tab_logs_render.snap | Snapshot update for new logs viewer UI and key hints. |
| src/snapshots/pdm__ui__tests__bitcoin_status_screen_render.snap | Snapshot update for chain info tab rendering prompt. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+425
to
+431
| pub fn copy_filtered_bitcoin_logs(&mut self) { | ||
| let text = self.filtered_bitcoin_log_lines().join("\n"); | ||
| if text.is_empty() { | ||
| self.bitcoin_log_status = "No Bitcoin Core log lines to copy.".to_string(); | ||
| return; | ||
| } | ||
|
|
Comment on lines
+292
to
+294
| fn default_data_dir() -> Option<PathBuf> { | ||
| std::env::var_os("HOME").map(|home| PathBuf::from(home).join(".bitcoin")) | ||
| } |
Comment on lines
+61
to
+78
| let mut position = file_len; | ||
| let mut newline_count = 0usize; | ||
| let mut chunks: Vec<Vec<u8>> = Vec::new(); | ||
|
|
||
| while position > 0 && newline_count <= max_lines { | ||
| let read_size = READ_CHUNK_SIZE.min(position); | ||
| position -= read_size; | ||
|
|
||
| file.seek(SeekFrom::Start(position)) | ||
| .with_context(|| format!("could not seek {}", path.display()))?; | ||
|
|
||
| let mut chunk = vec![0u8; read_size as usize]; | ||
| file.read_exact(&mut chunk) | ||
| .with_context(|| format!("could not read {}", path.display()))?; | ||
|
|
||
| newline_count += chunk.iter().filter(|byte| **byte == b'\n').count(); | ||
| chunks.push(chunk); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT PR