You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update the WhatsApp SDK lockfile pin to 14661bb40 and adapt the client to the SDK's millisecond Timestamp type. Convert at SDK boundaries so IPC dates and stored timestamps retain their existing representation. Keep the existing wall clock and use integer milliseconds directly where the client already expects them.
Validation
Workspace check with all targets passed against both SDK revisions, 08f07dd9e and 14661bb40.
Core unit tests passed on the final source. The 251 passing tests include coverage of the SDK timestamp range and signed epoch milliseconds. Two tests were ignored.
For the size A/B, the client source is fixed. The two lockfiles vary only by the SDK revision. Cargo manifests and build flags stay unchanged.
Release blocker
The daemon release link on 08f07dd9e and the chat-store test link on 14661bb40 both fail on sqlite3_progress_handler. The current SDK selects Diesel 2.4, which references that symbol during SQLite connection cleanup. The existing bundled SQLite configuration defines SQLITE_OMIT_PROGRESS_CALLBACK, so the symbol is absent.
This draft contains the timestamp migration independently of the SQLite compatibility decision. The accumulated size comparison still requires working release links with a common configuration.
Summary by cubic
Adapts the client to the SDK's millisecond Timestamp type, converting at the SDK boundary so IPC dates and stored timestamps keep their existing UTC representation.
Pins the WhatsApp SDK lockfile to 14661bb40.
Adds crates/core/src/time.rs with from_sdk and now_utc conversion helpers.
Uses .as_millis() and the SDK's now_millis() where integer milliseconds are needed.
Updates tests to build SDK timestamps through the new helper.
Release blocker
The daemon release link and chat-store test link fail on sqlite3_progress_handler because the SDK now selects Diesel 2.4, which references that symbol while the bundled SQLite config omits it.
Written for commit db24f26. Summary will update on new commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the WhatsApp SDK lockfile pin to
14661bb40and adapt the client to the SDK's millisecond Timestamp type. Convert at SDK boundaries so IPC dates and stored timestamps retain their existing representation. Keep the existing wall clock and use integer milliseconds directly where the client already expects them.Validation
08f07dd9eand14661bb40.Release blocker
The daemon release link on
08f07dd9eand the chat-store test link on14661bb40both fail onsqlite3_progress_handler. The current SDK selects Diesel 2.4, which references that symbol during SQLite connection cleanup. The existing bundled SQLite configuration definesSQLITE_OMIT_PROGRESS_CALLBACK, so the symbol is absent.This draft contains the timestamp migration independently of the SQLite compatibility decision. The accumulated size comparison still requires working release links with a common configuration.
Summary by cubic
Adapts the client to the SDK's millisecond
Timestamptype, converting at the SDK boundary so IPC dates and stored timestamps keep their existing UTC representation.14661bb40.crates/core/src/time.rswithfrom_sdkandnow_utcconversion helpers..as_millis()and the SDK'snow_millis()where integer milliseconds are needed.Release blocker
The daemon release link and chat-store test link fail on
sqlite3_progress_handlerbecause the SDK now selects Diesel 2.4, which references that symbol while the bundled SQLite config omits it.Written for commit db24f26. Summary will update on new commits.