ensure fake OS phase 2 images contain the version#48
Merged
Conversation
iliana
force-pushed
the
iliana/fake-os-image-oops
branch
from
July 8, 2026 04:05
9318024 to
d88862b
Compare
iliana
force-pushed
the
iliana/fake-os-image-oops
branch
from
July 8, 2026 18:08
d88862b to
bdb71b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the late changes to generating fake artifacts in the rewrite PR broke the rule that images of different versions must have different contents. Tests on my Nexus integration branch caught this mistake. This adds a test to ensure the rule holds between two fake repos of version
1.0.0and2.0.0, and fixes fake OS phase 2 image generation.