[21/n] [wicketd] compute transceiver staleness at read time, per switch#10888
Conversation
Created using spr 1.3.6-beta.1
1 task
jgallagher
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while reviewing #10857.
Currently, for transceivers:
last_seenacross both switches.last_seenis snapshotted at update time, which means that it would only measure how long the update was in the mpsc channel for.Both of these seem incorrect, and in particular the second one would show up as wicket always reporting <1s.
Fix both these issues.
To maintain the same wire shape, for point 1 we pick
max. (The commissioning API will publish per-switch last seen values.) For point 2 there will be a behavior change visible in wicket, but that seems correct.