[15/n] [update-engine] use oxide-update-engine from crates.io, delete the vendored copy#10868
Merged
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
1 task
Contributor
Author
|
Testing notes (on dublin): First, installed main (720bec2): (The goal of starting from main is to ensure that there isn't behavioral and wire protocol divergence across main's version of update-engine and this PRs.) Once that was successful, installed this PR: The update completed successfully: 
(This isn't surprising -- it's almost entirely the same code.) |
sunshowers
changed the title
sunshowers
changed the title
sunshowers
marked this pull request as ready for review
July 21, 2026 01:30
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jul 21, 2026
sunshowers
changed the base branch from
sunshowers/spr/main.14n-update-engine-adopt-the-oxide-update-engine-crates-delete-the-vendored-copy
to
main
July 21, 2026 17:52
Created using spr 1.3.6-beta.1
sunshowers
enabled auto-merge (squash)
July 21, 2026 17:54
sunshowers
deleted the
sunshowers/spr/14n-update-engine-adopt-the-oxide-update-engine-crates-delete-the-vendored-copy
branch
July 21, 2026 22:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved these crates to crates.io a while ago, and they have a few important bugfixes and features that smoothen the process of integrating #10857.
There aren't any wire protocol changes, so this can be landed without breaking rkdeploy.
TODO: