update rust toolchain to 1.97.1#10847
Open
iliana wants to merge 2 commits into
Open
Conversation
iximeow
approved these changes
Jul 18, 2026
iximeow
left a comment
Member
There was a problem hiding this comment.
helios#263 notwithstanding, nice, yeah, maybe 1.97.1 is finally when there won't be miscompilations!
re. the lint: if you do want to disable the lint here I think that's fine, because I read the note as "lint for existing regressions", not "rustc stopped optimizing double references". and if anyone cares about the throughput of format!() .. I'm sorry for them ... but since the deed is done this sgtm
sunshowers
approved these changes
Jul 18, 2026
Collaborator
Author
knocks on several wood pallets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to pick up a optimization miscompilation fix, but be aware that
-Csymbol-mangling-version=v0is along for the ride too. I seem to remember some chatter in #oxide-rust that this is fine?https://blog.rust-lang.org/2026/07/09/Rust-1.97.0/
https://blog.rust-lang.org/2026/07/16/Rust-1.97.1/
The bulk of the churn here is https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting. I would normally have disabled the lint to avoid the churn but:
This will almost certainly result in "semantic merge conflicts" shortly after this PR lands. I will ask people to be vigilant but there is no real guard rail so it will happen anyway.
Note there is a new warning:
proc-macro-error2 is unmaintained and is brought in through tabled_derive. tabled has merged a change which removes the unmaintained dependency but this has not yet landed in a release.