plumb interface w/ default route for service zones#10837
Draft
rcgoodfellow wants to merge 1 commit into
Draft
Conversation
jgallagher
reviewed
Jul 16, 2026
| impl Route { | ||
| pub async fn ensure_default_route_with_gateway( | ||
| gateway: Gateway, | ||
| datalink: Option<&str>, |
Contributor
There was a problem hiding this comment.
Small nit: can we make this non-optional? At that point I believe we can also make the datalink parameter to ensure_route_with_gateway non-optional too - this method was the only caller of it that passed None.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses flaky webhook delivery described in
opte0interface is (at least sometimes?) broken #10829More complete writeup on the way pending a bit more testing.