add some tests for insert_overwrite/from_iter_unique behavior#304
Merged
sunshowers merged 3 commits intoJul 19, 2026
Conversation
Created using spr 1.3.6-beta.1
There was a problem hiding this comment.
Pull request overview
Adds integration tests that pin down IdOrdMap::from_iter_unique duplicate reporting and exercise fail-fast behavior when an item’s key changes mid-operation (notably around insert_overwrite / from_iter_unique), as preparation for the refactor discussed in #303.
Changes:
- Add
IdOrdMap::from_iter_uniquetests for duplicate-key error reporting and empty iterators. - Introduce
FlipItempathological tests coveringinsert_overwritepanics andfrom_iter_uniquebehavior under key-flip scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/iddqd/tests/integration/pathological.rs | Adds FlipItem and new pathological tests validating fail-fast panics and post-panic map validity for flip-key scenarios. |
| crates/iddqd/tests/integration/id_ord_map.rs | Adds standard integration tests for from_iter_unique duplicate errors and empty-iterator behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/add-some-tests-for-insert_overwritefrom_iter_unique-behavior
branch
July 19, 2026 22:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for #303.
FlipItemtests.