Skip to content

Point to insert_unique in code comment for IdOrdMap::from_iter_unique #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunshowers merged 2 commits into from
Jul 17, 2026
Merged

Point to insert_unique in code comment for IdOrdMap::from_iter_unique #300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e45fc
Point to insert_unique in from_iter_unique code comment
izuzak Jul 16, 2026
a6b014b
Rewrap the comment to 80 chars per line
izuzak Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/iddqd/src/id_ord_map/imp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,9 @@ impl<T: IdOrdItem> IdOrdMap<T> {
) -> Result<Self, DuplicateItem<T>> {
let mut map = IdOrdMap::new();
for value in iter {
// It would be nice to use insert_overwrite here, but that would
// return a `DuplicateItem<T, &T>`, which can only be converted into
// an owned value if T: Clone. Doing this via the Entry API means we
// It would be nice to use insert_unique here, but that would return
// a `DuplicateItem<T, &T>`, which can only be converted into an
// owned value if T: Clone. Doing this via the Entry API means we
// can return a `DuplicateItem<T>` without requiring T to be Clone.
match map.entry(value.key()) {
Entry::Occupied(entry) => {
Expand Down
Loading