Drop to line-tables-only for debug in new binrelease profile#717
Open
jamesmunns wants to merge 1 commit into
Open
Drop to line-tables-only for debug in new binrelease profile#717jamesmunns wants to merge 1 commit into
binrelease profile#717jamesmunns wants to merge 1 commit into
Conversation
This allows for retaining panic messages and backtraces, without retaining all debuginfo. On linux, this is a significant size savings, 516.1MiB -> 181.4MiB, and also is a bit quicker to build, about 2m10s vs 2m41s on my Ryzen 1700X systems. This is an opt-in change, as it requires --profile binrelease, but this new profile is used for the nightly workflow, meaning that CI will pull this instead of the --release binary.
Contributor
Author
|
Somewhat hilariously, after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for retaining panic messages and backtraces, without retaining all debuginfo. On linux, this is a significant size savings, 516.1MiB -> 181.4MiB, and also is a bit quicker to build, about 2m10s vs 2m41s on my Ryzen 1700X system.
This is an opt-in change, as it requires --profile binrelease, but this new profile is used for the nightly workflow, meaning that CI will pull this instead of the --release binary.
This should only be a functional change if anyone is trying to debug humility itself, e.g. using
gdb.I've seen some CI failures when pulling this file, and it might be due to the size (I have no proof of this):
https://github.com/oxidecomputer/hubris/actions/runs/29899522236/job/88859630586
We might want to do something similar for whatever gets packaged for illumos as well, or we could consider making this the default for the
releaseprofile.Docs for
debug: https://doc.rust-lang.org/cargo/reference/profiles.html#debug, discussingline-tables-only.