Remove a Volume's jobs when detaching#1954
Merged
Merged
Conversation
When detaching a Volume from the Pantry, garbage-collect all the related jobs. A previous commit changed the implementation of `attach` to be implemented in terms of `attach_activate_background`, and this used the volume_id as the supplied job_id, This caused a problem because the re-use of a job_id isn't allowed, meaning that clients of the Pantry could only attach a volume once!
leftwo
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When detaching a Volume from the Pantry, garbage-collect all the related jobs. A previous commit changed the implementation of
attachto be implemented in terms ofattach_activate_background, and this used the volume_id as the supplied job_id, This caused a problem because the re-use of a job_id isn't allowed, meaning that clients of the Pantry could only attach a volume once!