Skip to content

fix: migrate from deprecated module.register() to module.registerHooks() #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjnoname wants to merge 1 commit into from
Closed

fix: migrate from deprecated module.register() to module.registerHooks() #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions packages/core/register.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import * as NodeModule from "node:module";
import { addHook } from "pirates";

import { OxcTransformer } from "./index.js";
import { createResolve, initTracing, load } from "./index.js";

// Destructure from NodeModule namespace to support older Node.js versions
const { register, setSourceMapsSupport } = NodeModule;
const { registerHooks, register, setSourceMapsSupport } = NodeModule;

const DEFAULT_EXTENSIONS = new Set([
".js",
Expand All @@ -20,7 +20,25 @@ const DEFAULT_EXTENSIONS = new Set([
".es",
]);

register("@oxc-node/core/esm", import.meta.url);
// Use registerHooks (Node.js >= 24.4) when available, fall back to deprecated register()
if (typeof registerHooks === "function") {
initTracing();

// Wrap resolve to strip fields not recognized by the native binding
function resolve(specifier, context, nextResolve) {
const { parentURL, conditions } = context;
return createResolve(
{ getCurrentDirectory: () => process.cwd() },
specifier,
{ parentURL, conditions },
nextResolve,
);
}

registerHooks({ resolve, load });
} else {
register("@oxc-node/core/esm", import.meta.url);
}

if (typeof setSourceMapsSupport === "function") {
setSourceMapsSupport(true, { nodeModules: true, generatedCode: true });
Expand Down