refactor: deduplicate workflow steps via composite actions#50
Draft
DeepDiver1975 wants to merge 15 commits into
Draft
refactor: deduplicate workflow steps via composite actions#50DeepDiver1975 wants to merge 15 commits into
DeepDiver1975 wants to merge 15 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rnary Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… resolve Reusable workflows run in a fresh workspace — ./.github/actions/* doesn't exist until the repo is checked out. Check out owncloud/reusable-workflows into _rw/ at github.workflow_sha as the first step in each workflow, then reference composite actions as ./_rw/.github/actions/.... Add clean: false to subsequent checkouts that would otherwise wipe the _rw/ directory. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/actions/to eliminate copy-pasted step clusters across 5 workflowssetup-owncloud-env: consolidates the checkout cluster (validate app-repository, clone core, checkout app, optional additional-app) — used byphp-codestyle,php-unit,js-unitsetup-php-server: consolidates PHP setup + server install — single source of truth for theshivammathur/setup-phpSHA pin and database switching logicgithub-app-pr: consolidates GitHub App token generation + PR creation — fixes version drift betweentranslation-sync(v3.1.1) andcalens(v1.11.6) foractions/create-github-app-tokenSecurity improvements (carried in from fixup commits)
persist-credentials: falseadded to all checkout steps insetup-owncloud-envadditional-packagesinput validated against an allowlist regex beforeapt-get(same pattern as fix(security): prevent command injection via additional-packages input #40/fix(security): prevent command injection via additional-app input #42)php occ maintenance:installarguments are now properly quoted (no more unquoted variable expansion)fail-fast: truenon-functional env var removed fromshivammathur/setup-phpstepBug fix
case()expression inphp-codestyleandphp-unitcore-ref selection (not a valid GitHub Actions function) with the correct&&/||ternary idiomImpact
shivammathur/setup-phppinsactions/create-github-app-tokenpinspeter-evans/create-pull-requestpinsTest plan
python3 -c "import yaml; yaml.safe_load(open(f))"(verified locally)php-codestyleworkflow on a test app to confirm checkout + PHP setup + style checks workphp-unitworkflow with SQLite and at least one DB (mysql/postgres) to confirm database switchingjs-unitworkflow to confirm combined setup-app step workstranslation-syncon a branch to confirm token + PR step fires correctlycalenson a branch to confirmbasebranch is set on the PR🤖 Generated with Claude Code