Skip to content

IIS: fix dead Host header fallback (r->hostname == NULL can never be true) #3622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A13501350 wants to merge 1 commit into
base: v2/master
Choose a base branch
from
+1 −1
Open

IIS: fix dead Host header fallback (r->hostname == NULL can never be true) #3622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iis/mymodule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@
}

REQUEST_NOTIFICATION_STATUS
CMyHttpModule::OnBeginRequest(

Check failure on line 718 in iis/mymodule.cpp

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 45 to the 25 allowed. 


See more on https://sonarcloud.io/project/issues?id=owasp-modsecurity_ModSecurity&issues=AaBCZ0zJ6193acJ4eyu-&open=AaBCZ0zJ6193acJ4eyu-&pullRequest=3622
IN IHttpContext * pHttpContext,
IN IHttpEventProvider * pProvider
)
Expand Down Expand Up @@ -840,7 +840,7 @@
r->hostname = ConvertUTF16ToUTF8(req->CookedUrl.pHost, req->CookedUrl.HostLength / sizeof(WCHAR), r->pool);
r->path_info = ConvertUTF16ToUTF8(req->CookedUrl.pAbsPath, req->CookedUrl.AbsPathLength / sizeof(WCHAR), r->pool);

if(r->hostname == NULL)
if(r->hostname == NULL || r->hostname[0] == '\0')
{
if(req->Headers.KnownHeaders[HttpHeaderHost].pRawValue != NULL)
r->hostname = ZeroTerminate(req->Headers.KnownHeaders[HttpHeaderHost].pRawValue,
Expand Down
Loading