fix(gateway): discard abandoned Pi session files on /new - #182
Open
AuYahyire wants to merge 1 commit into
Open
Conversation
Rotate already drops the DB pointer; also delete the matching Pi JSONL under ~/.pi/agent/sessions so /clear|/new|/reset do not leave orphan session files. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/clear/new/reset, Push already rotates the DB session pointer; for the Pi backend it now also deletes the matching abandoned*_<session-id>.jsonlunder~/.pi/agent/sessions(or$PI_CODING_AGENT_DIR/sessions).store::rotatereturns the previous session id so callers can clean up backend artifacts.Why
Pi leaves session JSONL files on disk after Push rotates the conversation. Without cleanup,
/neworphans large session files and grows~/.pi/agent/sessionsunbounded.Test plan
cargo fmt --all --checkcargo clippy --locked --all-targets -- -D warningscargo build --lockedcargo test --lockedcargo test discards_matching_session_jsonl_onlycargo test clear_rotates_only_the_exact_channel_qualified_sessionagent=pi, send a chat turn,/new, confirm the previous~/.pi/agent/sessions/**/*_<old-id>.jsonlis gone and the thread still worksRisks
*_<session-id>.jsonland ignores unsafe ids.Related issue
None