fix(update): a run of dev builds could hide stable releases - #80
Merged
Conversation
added 2 commits
August 3, 2026 19:49
The check read one page of a hundred registry tags. Tags come back ordered by recency rather than by version, so publishing a hundred development builds after a release fills that page with X.Y.Z-dev.N — every one of which a stable deployment filters out. It is then left with no version tags at all and reports "you're up to date" to someone who is not. Worth fixing ahead of what the arithmetic suggests, because of how it fails: silently, only for people on older versions, only on the stable channel, with nothing logged anywhere. That is the signature of the bug that started this work. It now follows the next page, but only while it has found nothing usable. In the ordinary case the newest release is on the first page and this makes exactly one request, as before. Bounded at five pages so a registry that keeps offering another cannot hang the request, and it rejects rather than resolving empty on an unparseable response — resolving empty would be indistinguishable from "nothing published" and would report the same false reassurance. The fetch moved into updater.js, where it can be tested; the route was the only place it could live before and could not be exercised. Eight tests, and I checked the important one fails with paging disabled rather than assuming it exercises anything.
package.json is still 1.8.1, so merging this republishes that version rather than cutting a new one — the fix ships as part of 1.8.1 and belongs in its section, next to the other tag-listing fault it is a sibling of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check read one page of a hundred registry tags. Tags come back ordered by recency rather than by version, so publishing a hundred development builds after a release fills that page with X.Y.Z-dev.N — every one of which a stable deployment filters out. It is then left with no version tags at all and reports "you're up to date" to someone who is not.
Worth fixing ahead of what the arithmetic suggests, because of how it fails: silently, only for people on older versions, only on the stable channel, with nothing logged anywhere. That is the signature of the bug that started this work.
It now follows the next page, but only while it has found nothing usable. In the ordinary case the newest release is on the first page and this makes exactly one request, as before. Bounded at five pages so a registry that keeps offering another cannot hang the request, and it rejects rather than resolving empty on an unparseable response — resolving empty would be indistinguishable from "nothing published" and would report the same false reassurance.
The fetch moved into updater.js, where it can be tested; the route was the only place it could live before and could not be exercised. Eight tests, and I checked the important one fails with paging disabled rather than assuming it exercises anything.
Summary
Test plan
Pre-merge checklist
Code quality:
Version & Release:
frontend/package.jsonversiondocker-compose.ymlAPP_VERSIONCHANGELOG.mdwith release notesBefore merging to main:
Related issues