Skip to content

[JSC] A failed loadModule() stores its error in the registry entry it loaded - #754

Open
robobun wants to merge 2 commits into
mainfrom
robobun/4ad8a864/module-load-error-own-entry
Open

[JSC] A failed loadModule() stores its error in the registry entry it loaded#754
robobun wants to merge 2 commits into
mainfrom
robobun/4ad8a864/module-load-error-own-entry

[JSC] A load whose fetch failed leaves another load's entry alone, an…

08bf097
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 3, 2026 in 30m 36s

Code review found 2 potential issues

Found 6 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 2
Severity File:Line Issue
🟣 Pre-existing Source/JavaScriptCore/runtime/JSMicrotask.cpp:1261 Pre-existing: after an import() of a key fails with a tagged error, any later static import of that key never settles. J
🟣 Pre-existing Source/JavaScriptCore/runtime/JSMicrotask.cpp:1195 Bun users who call build.module() or delete a cached module right after an import() of an already-loaded module still ge
View more details on Claude