Skip to content

Update engagement pricing and founder bio - #190

Merged
gocanto merged 4 commits into
mainfrom
agent/remove-site-prices
Jul 18, 2026
Merged

Update engagement pricing and founder bio#190
gocanto merged 4 commits into
mainfrom
agent/remove-site-prices

Conversation

@gocanto

@gocanto gocanto commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove displayed prices from all four engagement offerings
  • replace each engagement action with a simple More info link to the contact page
  • remove the obsolete price field from the content type
  • add regression coverage for the contact links and absence of currency values
  • point the About-page founder bio link to https://gocanto.sh
  • add rel="me" identity metadata and founder Person structured data

Why

Engagement pricing should no longer be published on the site, so visitors are directed to the contact page for more information. The founder bio and SEO metadata now use Gustavo Ocanto's canonical website.

Validation

  • pnpm exec vitest run tests/pages/WorkWithUsPage.test.ts
  • pnpm exec vitest run tests/pages/AboutPage.test.ts tests/support/seo-content.test.ts
  • pnpm run lint (passes with three existing unrelated warnings)
  • pnpm run build
  • Playwright verified all four links and navigation to /contact
  • Playwright verified the rendered founder link, rel="me", and JSON-LD URL

Summary by CodeRabbit

  • New Features
    • Engagement cards now show “More info” contact links, with clearer details on what’s included and the expected outcome.
    • Added founder metadata to the site’s organisation info and structured data, and updated the founder bio link text and destination.
  • Bug Fixes
    • Removed outdated engagement price displays and updated CTA presentation (including improved accessibility labelling).
  • Tests
    • Added coverage for “More info” links, ensuring prices are no longer shown, and validating the new founder SEO metadata.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the site's engagement offerings by removing explicit pricing and streamlining the user journey. By replacing specific price points with a direct link to the contact page, the site encourages more personalized communication with potential clients. The changes include updates to the UI, data structures, and test suite to ensure consistency and prevent future regressions.

Highlights

  • Pricing Removal: Removed all pricing information from the engagement offerings on the Work With Us page.
  • CTA Update: Replaced existing call-to-action buttons with a consistent 'More info' link directing users to the contact page.
  • Schema Cleanup: Removed the obsolete 'price' field from the WorkWithUsPageContent interface.
  • Regression Testing: Added automated tests to verify the presence of contact links and ensure no currency values are displayed.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fa1c5ef6-78ba-4964-82ea-fcf2b3d6186f

📥 Commits

Reviewing files that changed from the base of the PR and between dda87f2 and 56bb703.

📒 Files selected for processing (2)
  • src/pages/WorkWithUsPage.vue
  • tests/pages/WorkWithUsPage.test.ts

Walkthrough

The Work With Us engagement cards no longer display prices and now use “More info” links to /contact. Founder data is added to site content, the About page link, and organisation JSON-LD, with tests covering both updates.

Changes

Engagement CTA update

Layer / File(s) Summary
Engagement contract and CTA rendering
src/support/content-types.ts, src/pages/WorkWithUsPage.vue, storage/fixtures/work-with-us-page.json
The engagement type removes price, adds inclusion and outcome fields, and renders configured CTAs with blog-link styling. All four fixture CTAs use “More info” and retain /contact.
Engagement CTA validation
tests/pages/WorkWithUsPage.test.ts
Tests verify that each engagement renders a “More info” link to /contact and that prices are absent.

Founder metadata update

Layer / File(s) Summary
Founder content and link wiring
src/support/content-types.ts, storage/fixtures/site.json, storage/fixtures/about-page.json, src/pages/AboutPage.vue, tests/pages/AboutPage.test.ts
Founder name and URL are added to site content, the About page link points to the founder bio, and the link includes rel="me".
Founder structured data
src/support/seo.ts, index.html, tests/support/seo-content.test.ts
Organisation JSON-LD identifies the founder as a Person, with tests verifying the configured name and canonical bio URL.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • oullin/web#51: Introduced the SEO/JSON-LD system extended here with organisation founder metadata.
  • oullin/web#186: Also updates the site’s Organization JSON-LD metadata in index.html.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the two main themes of the change: engagement pricing updates and the founder bio update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@gocanto
gocanto marked this pull request as ready for review July 18, 2026 09:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes pricing information from the "Work with Us" page engagements, updating the Vue component, TypeScript interfaces, fixture data, and unit tests accordingly. It also changes the call-to-action link text to "More info" and updates its styling. The reviewer noted an accessibility (a11y) issue where using repetitive "More info" links without context can hinder screen readers, and suggested adding an aria-label to provide descriptive context for each engagement option.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/pages/WorkWithUsPage.vue Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/pages/WorkWithUsPage.test.ts`:
- Line 34: Broaden the currency-removal assertion in the WorkWithUsPage test so
it rejects all site-supported displayed currency formats, including spaced
dollar amounts, decimal/k suffixes, pound and euro values, and trailing USD
amounts. Keep the assertion focused on rendered text and ensure legacy price
values cannot pass unnoticed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46a77c14-b443-49df-bbac-7280e8f77658

📥 Commits

Reviewing files that changed from the base of the PR and between e21b151 and 406801e.

📒 Files selected for processing (4)
  • src/pages/WorkWithUsPage.vue
  • src/support/content-types.ts
  • storage/fixtures/work-with-us-page.json
  • tests/pages/WorkWithUsPage.test.ts
💤 Files with no reviewable changes (1)
  • src/support/content-types.ts

Comment thread tests/pages/WorkWithUsPage.test.ts Outdated
@gocanto gocanto changed the title Remove engagement pricing from the site Update engagement pricing and founder bio Jul 18, 2026
@gocanto
gocanto marked this pull request as draft July 18, 2026 09:19

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/support/seo-content.test.ts`:
- Around line 50-58: Update the founder metadata test around the “connects the
organization founder metadata” case to parse the organization JSON-LD from
indexHtml and compare its complete founder object with
ORGANIZATION_JSON_LD.founder, covering `@type`, name, and url instead of checking
only the URL substring.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 02df5193-b61f-4ae5-a897-1f23e14c85c7

📥 Commits

Reviewing files that changed from the base of the PR and between 406801e and b6f82bb.

📒 Files selected for processing (8)
  • index.html
  • src/pages/AboutPage.vue
  • src/support/content-types.ts
  • src/support/seo.ts
  • storage/fixtures/about-page.json
  • storage/fixtures/site.json
  • tests/pages/AboutPage.test.ts
  • tests/support/seo-content.test.ts

Comment thread tests/support/seo-content.test.ts
@gocanto
gocanto marked this pull request as ready for review July 18, 2026 09:30

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/WorkWithUsPage.vue`:
- Line 54: Update the RouterLink in WorkWithUsPage to derive its aria-label from
engagement.cta.label, matching the link’s displayed text instead of hard-coding
“More info.”
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ce96cd32-13e3-4b05-85f3-d1783b85c403

📥 Commits

Reviewing files that changed from the base of the PR and between b6f82bb and dda87f2.

📒 Files selected for processing (3)
  • src/pages/WorkWithUsPage.vue
  • tests/pages/WorkWithUsPage.test.ts
  • tests/support/seo-content.test.ts

Comment thread src/pages/WorkWithUsPage.vue Outdated
@gocanto
gocanto marked this pull request as draft July 18, 2026 09:33
@gocanto
gocanto marked this pull request as ready for review July 18, 2026 09:35
@gocanto
gocanto merged commit abd3f0a into main Jul 18, 2026
8 of 9 checks passed
@gocanto
gocanto deleted the agent/remove-site-prices branch July 18, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant