Skip to content

feat: add documentation for deploying and testing LLM models with Ope… #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KUASWoodyLIN merged 1 commit into from
Jan 21, 2026
Merged

feat: add documentation for deploying and testing LLM models with Ope… #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/content/docs/demos/04-llm-model.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def ask_question(question):

try:
response = requests.post(
f"{SERVICE_URL}/v1/chat",
f"{SERVICE_URL}/v1/completions",
headers=headers,
json=payload
)
Comment on lines 88 to 92

@gemini-code-assist gemini-code-assist Bot Jan 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The requests.post call can be made more robust. It's missing a timeout, which can cause the script to hang indefinitely if the remote server is unresponsive. Additionally, concatenating URL parts with an f-string can be fragile if SERVICE_URL contains a trailing slash, leading to double slashes in the URL.

I'd recommend adding a timeout and also stripping any trailing slash from the service URL to make the code more resilient.

        response = requests.post(
            f"{SERVICE_URL.rstrip('/')}/v1/completions",
            headers=headers,
            json=payload,
            timeout=60  # Add a timeout to prevent requests from hanging
        )

Expand Down
Loading