chore: take the assistant tooling out of the repository - #114
Merged
Conversation
Two lines, and they were the only mentions left in tracked files. `.gitignore` listed `CLAUDE.md`, a file that was never committed — the entry existed so it could not be. With the file gone from the working copy too, the entry has nothing to ignore, and leaving it would keep a name in the repository for a file the repository does not have. `.dockerignore` excluded `.claude/` under "never ship history or local tooling state into the context", beside `.git/`, `.github/` and `node_modules/`. **That second one has a small cost, stated rather than buried:** if a `.claude/` directory ever appears at the root it now enters the Docker build context. It does not exist today, and `*.md` further down already keeps stray markdown out, so nothing changes for the images as they stand. The exclusion was hygiene, not a dependency — no build reads that path — but it was doing something, and this gives it up on purpose. Re-adding the line is the fix if a context ever grows for that reason. Nothing here touches the build: `cargo`, the Dockerfiles and the workflows never read either path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last two mentions of the assistant tooling from tracked files, and
the local
CLAUDE.mdalong with them..gitignoreCLAUDE.md.dockerignore.claude/.git/andnode_modules/.The one trade-off, stated rather than buried
Dropping
.claude/from.dockerignoremeans that if such a directory everappears at the repository root, it enters the Docker build context. It does
not exist today, and
*.mdfurther down already keeps stray markdown out, sonothing changes for the images as they stand.
The exclusion was hygiene, not a dependency — no build step reads that path, and
cargo, the Dockerfiles and the workflows are all indifferent to it. But it wasdoing something, and this gives it up deliberately. If a build context ever
grows for that reason, putting the line back is the whole fix.
Stacked on #113
This branch is based on
feature/migrate-dev-to-develop, not ondevelopdirectly, and the reason is the trap #113 exists to close.
developstill carries the oldgitflow.yml, which only triggers on pullrequests based on
devormain. A branch taken fromdeveloptoday wouldtherefore never run gitflow branch name — a required check on the
protect-developruleset — and this pull request would sit unmergeable waitingfor a job that cannot start.
Basing it on #113 carries the fixed workflow into the merge ref, so the check
runs. Merge #113 first; GitHub then recomputes this diff down to the two
lines above.