Repository navigation
go-profinet v0.8.0; LLDP management interface number and OID - #29
Merged
Merged
Conversation
…bors (needs go-profinet v0.8.0) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
go-profinet v0.8.0 was validated against recorded traffic of real equipment: NUL-trimmed DCP names, LLDP management interface number and OID, ERR-RTA answers. berOID bounds sub-identifiers to 32 bits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lldp neighborsJSON gainsmanagement_if_indexandmanagement_oid(dotted; Siemens devices send the PNO OID 1.3.6.1.4.1.24686); documented in docs/json-output.md. The OID decoder bounds sub-identifiers to 32 bits and falls back to hex for invalid input (unit-tested).make checkgreen locally (coverage 93.4%); SAST (gosec, opengrep) clean at all thresholds, 3 pre-existing accepted findings.🤖 Generated with Claude Code