feat: add s3 variant#2
Merged
Merged
Conversation
benchctl check <signal> (also run inside bench/bench-all): issues each suite query once per engine, parses the response into a result count, and scores every apples engine against a reference (the first apples engine that returns data). Catches what a latency run hides — a 200-but-empty response from a dialect gap, a broken filter, or missing data. Verdicts: ref / match / diff (count vs reference) / empty (missing data the reference returned) / none (no engine had data — matched nothing or out of window, not an engine fault) / err. Written to results/<signal>/correctness.csv and rendered as a Correctness matrix under each signal in REPORT.md.
…ss checks - correctness checks (benchctl check) for metrics/logs/traces: result-count vs reference, rendered in REPORT.md; run inside bench/bench-all - GreptimeDB added to logs (otel_logs) and traces (opentelemetry_traces) via native SQL over /v1/sql; v1.1.1 trace pipeline header; bumped to v1.1.1 - oteldb-s3 variant: embedded engine on the shared go-faster/fs S3 bucket (apples-to-apples object-store group), flush_interval so data reaches S3 - VictoriaLogs queries fixed (severity field, no service.name) - --only fast-loop mode; apples engines ignore native overrides; warmup 90->30s - pprof + EXPLAIN ANALYZE logs-perf investigation and storage-pushdown proposals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.