Fix raid config

[janhorstmann]

No description provided.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• Consider avoiding in-place mutation of node_attributes when popping target_raid_config (e.g. work on a shallow copy) so that callers or subsequent logic that may rely on the full attributes dict are not surprised by missing keys.
• When creating the stub node, the direct access to node_attributes["driver"] will raise a KeyError if the driver is not present; if this is a realistic scenario, guard this lookup or raise a clearer error to aid debugging.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider avoiding in-place mutation of `node_attributes` when popping `target_raid_config` (e.g. work on a shallow copy) so that callers or subsequent logic that may rely on the full attributes dict are not surprised by missing keys.
- When creating the stub node, the direct access to `node_attributes["driver"]` will raise a `KeyError` if the driver is not present; if this is a realistic scenario, guard this lookup or raise a clearer error to aid debugging.

## Individual Comments

### Comment 1
<location path="osism/tasks/conductor/ironic.py" line_range="368-369" />
<code_context>
+        # transitioned fast from managable to available later. It is also safer
+        # to not clean during sync, so that nodes may later be adopted with
+        # their provisioned data.
+        node = openstack.baremetal_node_create(
+            device.name, dict(automated_clean=False, driver=node_attributes["driver"])
+        )
+
</code_context>
<issue_to_address>
**issue:** Guard against missing `driver` in `node_attributes` when creating the stub node

This indexing will raise a `KeyError` if `driver` is ever omitted from `node_attributes`, which would abort the sync. Please either use `node_attributes.get("driver")` with a clear error, or validate/assert the presence of `driver` earlier so failures are explicit and easier to debug.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[janhorstmann]

Hey - I've found 1 issue, and left some high level feedback:

• Consider avoiding in-place mutation of node_attributes when popping target_raid_config (e.g. work on a shallow copy) so that callers or subsequent logic that may rely on the full attributes dict are not surprised by missing keys.

We do need to pop target_raid_config, because it cannot be updated as a node attribute, but is part of it.

• When creating the stub node, the direct access to node_attributes["driver"] will raise a KeyError if the driver is not present; if this is a realistic scenario, guard this lookup or raise a clearer error to aid debugging.

Fixed

[jklare]

LGTM. Was this tested anywhere?

[janhorstmann]

LGTM. Was this tested anywhere?

tested manually in the baremetal testbed