Restrict Behavior Annex property references to allowed unit types 🤖

[lwrage]

Summary

BA property references are not checked against the AS5506/3 Rev. A D.7 restriction that referenced properties be unitless or have a time unit.

The current implementation resolves and translates property references without an identified BA-specific unit-category check.

Reproduction

This issue comes from the source audit in ba/doc/conformance.md; no additional runtime reproduction was performed.

Expected behavior

Accept unitless and time-valued property references and report references to properties with other unit types at the property reference. Preserve the selected value and unit in the strict model.

Relevant code

• ba/org.osate.xtext.aadl2.ba/src/org/osate/xtext/aadl2/ba/translation/DeclarativeToStrictTranslator.java — toPropertyReference.
• ba/org.osate.ba/src/org/osate/ba/analyzers/AadlBaTypeChecker.java — property value type checking.
• ba/org.osate.xtext.aadl2.ba/src/org/osate/xtext/aadl2/ba/BehaviorAnnex.xtext — property-reference forms.

[lwrage]

Declarative versus instance boundary

The allowed-unit-category rule can be checked declaratively because it is a restriction on the referenced property definition and its declared property type: unitless or time-valued.

The current expected behavior goes further by requiring the selected value and unit to be preserved. That selection is instance-dependent for an element-prefixed reference such as element#P; a contained property association can override the value for one instance without changing the shared annex. Translation should preserve the owner path and property definition symbolically. Selection of the effective value and its written unit must occur against the corresponding instance object.

Tests should therefore split the definition-type diagnostic from instance-level value selection.