fix: write heat-stack-info.txt from Go module at the configured dir#244
Merged
Conversation
matbu
requested changes
Jun 4, 2026
matbu
left a comment
matbu
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just the requirements to adjust.
matbu
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) generates heat template files in expected location
The Ansible copy task used
delegate_to: localhostwhich wrote the file to the controller host rather than where the module runs, causing the reported path to never match the actual file location. Move file writing intocreate_heat_stack.govia a newoutput_dirparameter so the file is always created on the same host and at the exact path the user configured.(2) adds tests for volume lookup bug related to cinder volume mismatch