Repository navigation
test: adapt cloudx tests to Console V3 and staging API changes - #463
Merged
Merged
Conversation
The nightly cloudx tests against staging broke on changes outside this repo: - Console V3 renders login with Ory Elements v1. The inputs carry ory/form/node/input/<name> test IDs, the form is submitted with fetch so a login continuing to consent is answered with 422 browser_location_change_required, and the consent.ory.com cookie banner covers the consent screen's Allow button. - Session-authenticated project creation requires a workspace. - Since Go 1.27, the hydra config type error no longer names the struct field. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQhMvbXeT2HENW1Gdm5R9C
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly summarizes the primary change: adapting cloudx tests for Console V3, staging API changes, and updated error behavior. Description check The description clearly explains the causes, implemented changes, testing status, and remaining documentation-job failures. It does not reproduce the template headings or checklist, but the required c… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description clearly explains the causes, implemented changes, testing status, and remaining documentation-job failures. It does not reproduce the template headings or checklist, but the required change context is substantially complete.
-
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
golangci-lint supports Go 1.27 from v2.13.0, so the pin moves to v2.15.0. Its install script comes from golangci-lint.run: the script on the repository's abandoned master branch also matches the .sbom.json line in the checksums of every release since v2.12.2 and rejects the tarball. The newer staticcheck flags rs/cors' deprecated AllowOriginRequestFunc. The function never looks at the request, so AllowOriginFunc replaces it with the same behavior. There is no golang:1.27 image on Alpine 3.22, and the CGO build has to run on the musl it was linked against, so both stages of Dockerfile-build move to Alpine 3.24. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQhMvbXeT2HENW1Gdm5R9C
A free workspace holds two development projects, so with every project now in a workspace, the third one in a workspace fails with 402 quota_exceeded. SelectProjectWorkspace creates its project in a workspace of its own, which it then selects, and CreateProject creates two projects instead of three. GET /projects lists only projects shared with the identity directly, never workspace projects, so the ListProjects case for it has nothing to list once projects cannot be created outside a workspace. The workspace case covers sessions and workspace and project API keys. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQhMvbXeT2HENW1Gdm5R9C
Fixes GO-2026-6612 (critical), which fails the image vulnerability scan. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQhMvbXeT2HENW1Gdm5R9C
ory/docs only accepts changes to master through pull requests, so the direct push in ory/ci/docs/cli-next is rejected, and ORY_BOT_PAT no longer authenticates. The job stays defined so it can be re-enabled once the action publishes through a pull request. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQhMvbXeT2HENW1Gdm5R9C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly CI on
masterhas been red since Jul 29. Thecloudxtests run against staging and broke on three changes outside this repo:cloudx/project…into Go value of type stringinstead of naming the struct field.cloudx/clientPOST /projectsrequires aworkspace_id(cloud #15262).cloudxpackagesChanges
The Console V3 changes are in
testhelpers.go:ory/form/node/input/<name>test IDs, which are now on the<input>itself. Wait for the password field, which renders both on a first login and when reconfirming a session, and fill the identifier only if it is visible.browser_location_change_required, its only use of 422 in self-service flows. The check uses the status alone because the page navigates away and the body can be discarded before it is read.consent.ory.com. Its cookie banner covers the consent screen'sAllowbutton (#consent-manager-root … intercepts pointer events).The other changes:
clienttests create every project in a workspace and assert that creating one without a workspace fails.ory create projectalready requires a workspace, so users are not affected.projectasserts oncannot unmarshal number into Go, which holds across Go versions.Testing
Run locally against staging:
accountexperience,identity,oauth2,organizations,projectandrelationtuplespass.client, the preamble andfunc=Authenticatepass, covering a first login, a re-login with an existing session, consent, and authenticated API calls.clientsubtestsListProjects,CreateProjectandSelectProjectWorkspacewere not verified locally. Staging returned 429 on project creation from my IP. CI sends the rate-limit header, so this PR's run covers them.Not fixed here
The Generate docs job will still fail:
ORY_BOT_PAThas failed since Oct 7, most likely because it expired 90 days after its Jul 9 update. Thereleasejob uses the same secret.masterruleset rejects the bot's direct push.ory/ci/docs/cli-nextneeds a PR-based flow or a bypass actor. Hydra, Keto, Kratos and Oathkeeper use the same action.🤖 Generated with Claude Code
https://claude.ai/code/session_01UQhMvbXeT2HENW1Gdm5R9C
Summary by CodeRabbit
No user-facing changes are included in this update. The changes are limited to automated checks and test sign-in handling; the app’s features and behavior remain unchanged.