Fix out-of-bounds prefetch pointer arithmetic - #1
Open
russellromney wants to merge 1 commit into
Open
Conversation
russellromney
force-pushed
the
agent/fix-mincdc-prefetch-ub
branch
from
July 12, 2026 08:02
b07369f to
63ff49d
Compare
russellromney
marked this pull request as ready for review
July 13, 2026 05:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Use
wrapping_addwhen computing the three x86 SIMD prefetch addresses.Why
The 16 KiB prefetch distance routinely places the address beyond the input allocation. The prefetch instruction itself is non-faulting, but Rust's
ptr::addrequires the computed pointer to remain within or one past the allocation even when it is not dereferenced.wrapping_addpreserves the intended machine behavior without creating an invalid in-bounds-derived pointer.Validation
cargo fmt --all -- --checkcargo test --target x86_64-apple-darwin prefetch_pointer_may_wrap_beyond_a_short_sliceThe regression helper/test gives provenance-aware tools such as Miri a direct path that computes a deliberately far-out prefetch pointer from a one-byte slice without invoking a SIMD prefetch instruction.