ci: require maintainer review on every path through CODEOWNERS - #65
Merged
Merged
Conversation
Branch protection on main already requires a code-owner review, but the repository had no CODEOWNERS file, so the requirement named no owner. Every path now defaults to the maintainer, matching the runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
.github/CODEOWNERSwith every path defaulting to@AdeGneus, in the same layout as the runtime's. Branch protection onmainalready requires a code-owner review, and without a CODEOWNERS file that requirement had no owner to name.Type of change
feat- new SDK API, model, client, or helperfix- bug fix or contract correctiondocs- documentation onlytest- tests onlyrefactor- no behavior changesecurity- touches signing, validation, install safety, or trust boundariescontract-change- changes a cross-repo contract mirrored from ori-specs/runtimeRequired checklist
pytest -qpassesmypy ori_sdk testspassesruff check ori_sdk testspassesruff format --check ori_sdk testspasses.pyfile has the Apache-2.0 license headerori_sdk/__init__.pyare updated if a public API was addedContract and compatibility checklist
ori-specsor runtime behavior; it does not redefine runtime authoritySecurity-sensitive checklist
Not applicable: no signing, install, extraction or validation code changes.
If you used AI assistance
Related issue
None; repository hardening.
Testing notes
No code changes. GitHub validates the file on the PR (Files changed shows any CODEOWNERS syntax errors); CI runs the existing matrix.