Skip to content

ci: require maintainer review on every path through CODEOWNERS - #65

Merged
AdeGneus merged 2 commits into
mainfrom
ci/codeowners
Oct 1, 2026
Merged

AdeGneus merged 2 commits into
mainfrom
ci/codeowners

Conversation

@AdeGneus

@AdeGneus AdeGneus commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds .github/CODEOWNERS with every path defaulting to @AdeGneus, in the same layout as the runtime's. Branch protection on main already requires a code-owner review, and without a CODEOWNERS file that requirement had no owner to name.

Type of change

  • feat - new SDK API, model, client, or helper
  • fix - bug fix or contract correction
  • docs - documentation only
  • test - tests only
  • refactor - no behavior change
  • security - touches signing, validation, install safety, or trust boundaries
  • contract-change - changes a cross-repo contract mirrored from ori-specs/runtime

Required checklist

  • Linked issue is included below and acceptance criteria are addressed
  • pytest -q passes
  • mypy ori_sdk tests passes
  • ruff check ori_sdk tests passes
  • ruff format --check ori_sdk tests passes
  • Pre-commit passes for changed files
  • Every new .py file has the Apache-2.0 license header
  • Public exports in ori_sdk/__init__.py are updated if a public API was added
  • Fixtures were added/updated for schema-facing contract changes

Contract and compatibility checklist

  • This PR mirrors ori-specs or runtime behavior; it does not redefine runtime authority
  • If gateway, hub, health, signing, or skill-package contracts changed, the matching repo/spec PR is linked
  • Backward compatibility impact is explained, or the issue explicitly allows a breaking change

Security-sensitive checklist

Not applicable: no signing, install, extraction or validation code changes.

If you used AI assistance

  • I can explain every line of AI-generated code in this PR
  • I have read and understood every file I modified
  • I am not submitting code I cannot defend in review

Related issue

None; repository hardening.

Testing notes

No code changes. GitHub validates the file on the PR (Files changed shows any CODEOWNERS syntax errors); CI runs the existing matrix.

Branch protection on main already requires a code-owner review, but the repository had no CODEOWNERS file, so the requirement named no owner. Every path now defaults to the maintainer, matching the runtime.
@AdeGneus AdeGneus self-assigned this Oct 1, 2026
@AdeGneus
AdeGneus merged commit 8891938 into main Oct 1, 2026
6 checks passed
@AdeGneus
AdeGneus deleted the ci/codeowners branch October 1, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant