docs(welcome): cite the design-system tokens without a private repository path - #52
Merged
Merged
Conversation
…tory path The comment recording where the welcome banner's colour values come from gave a file path inside a private downstream product's repository, which this public repository must not identify. The token names are what a reader needs to find them, and they are retained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The comment recording where the welcome banner's colour values come from gave a file path inside a private downstream product's repository. This public repository must not identify that product, and the path was the only string here that did.
The token names are what a reader actually needs in order to find the values, and they are retained. Nothing else in the comment carried provenance that the names do not.
This is the CLI half of a sweep that also covers the runtime and the contracts:
ori-platform/ori-runtime#597andori-platform/ori-specs#183.Type of change
docs- documentation onlyRequired checklist
go test ./...passesgo vet ./...passes.gofile has the Apache-2.0 license headerNo linked issue: this is the tracked-file remainder of a sweep carried out directly. No flags, help text or JSON output changed.
If you used AI assistance
Testing notes
gofmt -l,go vet ./...andgo build ./...are clean, andgo test ./...passes every package. A repository-wide scan for the product's name in every casing finds nothing left.