Repository navigation
Delegate search text and language filtering to BookOrbit - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShadowLib rebuilt keyword queries instead of using BookOrbit’s search-text helper and rejected language aliases before BookOrbit could normalize them. Delegate keyword construction to
host.buildSearchText, retain active ISBN handling, and return declared language metadata for BookOrbit’s filtering.Remove the now-unneeded language argument from catalogue merging. Provider-specific API encoding, format/media capability checks, duplicate-file merging, mirror failover, credential trust and all deadline/session controls remain intact.
Validation:
pnpm checkpassed (71 unit tests and two release tests). New regressions fail against the previous code and cover host-supplied keyword text, unchanged ISBN requests and language metadata passthrough. No live provider calls or downloads.Release v0.1.22 using the existing signing workflow.