Repository navigation
Preserve completed searches within BookOrbit’s deadline - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShadowLib could discard completed catalogue results when slow libraries exhausted BookOrbit’s search deadline. Give each query one eight-second budget including discovery, start the five library families concurrently, and retain completed results in configured order when the deadline interrupts unfinished work.
Incomplete searches with no usable results now report a failure instead of claiming no matches. Caller cancellation still rejects the operation; browser session serialization and per-mirror limits remain intact.
Validation:
pnpm check; regression fails on the original code at the caller deadline and passes with a completed Memory result in approximately eight seconds. Tests also cover empty partial outcomes and caller cancellation. Fixture coverage does not establish live provider availability or remove Anna’s HTTP 403 blocking.Releases v0.1.21 through the existing signing workflow.