Skip to content

fix(web): clarify File link folders setting description - #248

Merged
orbitingflea merged 1 commit into
mainfrom
feat/file-link-copy-neon
Nov 22, 2026
Merged

orbitingflea merged 1 commit into
mainfrom
feat/file-link-copy-neon

Conversation

@orbitingflea

Copy link
Copy Markdown
Owner

This pull request rewrites the description of the File link folders setting so users can understand it at a glance.

改了什么行为

Behaviour change: yes, users viewing Settings → Appearance → File link folders see a shorter, plain-English description under the setting title.

The description now reads "Choose how many folders to show before the name on file links in messages and Markdown previews." instead of the previous two-sentence wording. The title, dropdown options, search terms, storage key, and link behavior stay unchanged.

Why

The old description opened with a hard-to-parse noun fragment and mixed in device-scope and repeated-filename edge cases. The new line matches neighboring Appearance settings while README.md keeps the repeated-filename detail.

Checks

  • vp run check:changed passes (format, lint, knip, typecheck, React compiler).
  • fileLinkPathDepth unit, contract, and browser tests pass (3 files, 26 tests).
  • Desktop and narrow mobile renders of Settings → Appearance show no clipping or overlap.

How to undo

Revert the commit. No stored settings change.

Rewrite the description in FileLinkPathDepthSetting to one plain-English sentence that matches neighboring Appearance settings.
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XS labels Nov 22, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 99c0c3d.

This comment will update automatically after the next completed run.

@orbitingflea
orbitingflea merged commit b6b0957 into main Nov 22, 2026
43 of 45 checks passed
@orbitingflea
orbitingflea deleted the feat/file-link-copy-neon branch November 22, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant