Repository navigation
feat(web): Chat mode shows a floating Working line - #245
Merged
Merged
Conversation
Chat mode hides Normal's in-list Working row. It now shows "Working for <time>" on its own layer just above the composer, in the view where the active run answers: the Reply sub-thread of the run's latest typed message, else the main list. Chat mode keeps a fixed space for the line below the last message, so showing or hiding it moves nothing, and the Scroll to end button sits above that space. The run cards and the line share one placement rule, runPlaces. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This PR changes the test suite by +7 test cases (browser +1, unit +6, server 0). New browser test files: Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a "Working for" line with a running time to Chat mode. It floats just above the message box while the agent works.
改了什么行为
Behaviour change: yes, users of a thread in Chat mode see "Working for " above the message box while the agent works, in the main list or in the Reply sub-thread where the run answers.
The line shows in one place only. It shows in a sub-thread when the latest message the user typed in that run is a reply there. In all other cases it shows in the main list, for example when the user wrote in the main list, or when another agent, a scheduled task or a wake started the run. If the user writes somewhere else during the run, the line moves there after the server accepts the message. Closing the sub-thread does not move the line to the main list. Normal mode does not change.
Why
Chat mode hides Normal's Working row, so a user could not see that the agent was still busy, or for how long.
Checks
How to undo
Revert the commit. No stored data changes.
Details
How it works:
runPlaces, to find where a run answers. A run that only a notification started now has a place in the main list too. Cards keep their old place.Accepted tradeoffs:
/compactsent from a sub-thread shows the line there until the server answers, then in the main list. During a compaction the line says "Working for", not "Compacting".Surfaces not changed:
Upstream hooks:
ChatView.tsx: +24 lines, -3 lines. They add two imports, the reserved space for the follow logic and the list, the Scroll to end height, and the line element.