Repository navigation
fix(web): Chat mode draws input cards, renders and apps - #227
Merged
Merged
Conversation
These cases fail on main. Chat mode drops a waiting secret or link card, so the user cannot answer it. It also drops the agent's HTML renders and MCP apps, and the shown-only history leaves them out on reload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chat mode kept only messages. A secret or link card that waited for the user was dropped, so the thread showed "Input" with nothing to answer until the request timed out. The agent's HTML renders and MCP apps were dropped too. Chat mode now keeps a waiting secret or link card of this thread, and every render and app. Each shows where its run's answer shows: in the sub-thread of the message the user typed in that run, or else in the main list. The shown-only history loads these cards at their place and reads on until a card's run has its typed message, so a reload or an older page draws the same rows as the live view. The agent's message view reads no cards. Normal mode does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes Chat mode draw the secret and link cards that wait for the user, and the agent's HTML renders and MCP apps.
改了什么行为
Behaviour change: yes. In Chat mode, a secret or link request card shows while it waits, and the user can save, decline or link there. Renders and MCP apps show too. Each card shows where its run's answer shows: in the sub-thread of the message the user typed in that run, or else in the main list. Tool rows stay hidden, and Normal mode does not change.
Why
Chat mode drew only messages. When an agent called
request_secret, the sidebar showed "Input", but the thread showed no card, so the user could not answer until the request timed out. The client had the card; the Chat mode filter inapplyDisplayModedropped it. Renders and apps were dropped the same way. The shown-only history also left these rows out, so they could not come back on reload or in older pages. The history now loads them at their place and reads on until a card's run has the message the user typed in it, and the filter keeps them.Checks
How to undo
Revert both commits. No stored data changes.
Checks in detail
request_secrettool row stay hidden. A card from a run that a task or another agent started shows in the main list.t3_thread_user_viewstill list messages only. Changing the rules re-notifies every Chat thread.vp run check:changedpasses (format, lint, knip, typecheck, the tests beside the change).