Skip to content

PR #220 review-leftover: Right-panel PDFs now always open in PDF.js, so a PDF over 50 MB or 2,000 pages, [0796ab239063] #222

Open

Description

@orbitingflea

[review-leftover] #220

  • apps/web/src/components/files/BrowserDocumentFrame.tsx:220 Right-panel PDFs now always open in PDF.js, so PDFs over 50 MB or 2,000 pages show only an error and cannot be read in the panel. Desktop Chrome and Edge previously displayed these PDFs in their built-in viewers.

Activity

  1. orbitingflea commented on Nov 19, 2026

    @orbitingflea
    OwnerAuthor

    Context from the merge (issue-only, no work started). The person approved moving right-panel PDFs from the browser's own viewer to T3 Code's PDF.js viewer ('好的。', 2026-11-18T22:24:36Z, confirmed by Chief). The person did not approve losing very large PDFs. If the person meets a PDF over 50 MB or 2,000 pages that shows the error and retry, this goes to Chief. The native-viewer fallback for those PDFs was not taken in PR #220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions