Skip to content

refactor(runtime): remove applied storage migrations #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nol4lej merged 1 commit into from
Aug 4, 2026
Merged

refactor(runtime): remove applied storage migrations #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions frame/shielded-pool/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,23 @@

All notable changes to `pallet-shielded-pool` will be documented in this file.

## [0.13.0] - 2026-08-04

### Removed
- **`migrations` module.** Every live chain is at storage version v2 (verified
on-chain against testnet at block 283941), and a fresh chain starts there via
genesis, so `MigrateToV1`/`MigrateToV2` were no-ops guarded by their version
checks. Keeping `MigrateToV1` was a liability rather than a safety net: it
rebuilds the entire Merkle tree inside a single `on_runtime_upgrade`, which
cannot be split across blocks. At the testnet's 134201 leaves that is already
a ~4 MB `Vec` and ~270k writes in one block; at the 2^20 tree cap it would
exhaust the Wasm heap and produce a block no validator can import. Storage
version history stays documented on `STORAGE_VERSION`; see git history if an
old chain ever needs the code. The runtime's `Migrations` tuple is now empty.
`try-runtime` features are unaffected — they back `try_state`, not migrations.
`STORAGE_VERSION` itself is unchanged (still v2) — this removes the upgrade
path, not the on-chain layout.

## [0.12.0] - 2026-07-30

### Added
Expand Down
2 changes: 1 addition & 1 deletion frame/shielded-pool/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pallet-shielded-pool"
version = "0.12.0"
version = "0.13.0"
description = "Shielded pool pallet for private transactions using ZK proofs"
authors = ["Orbinum Team"]
license = "GPL-3.0-or-later"
Expand Down
10 changes: 5 additions & 5 deletions frame/shielded-pool/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ mod benchmarking;
pub mod genesis;
pub mod helpers;
pub mod merkle;
pub mod migrations;
pub mod operations;
pub mod storage;
pub mod types;
Expand Down Expand Up @@ -103,10 +102,11 @@ pub mod pallet {
<<T as Config>::Currency as Currency<<T as frame_system::Config>::AccountId>>::Balance;

/// Storage version history:
/// - v1: `MerkleNodes` (internal Merkle tree nodes), backfilled by
/// `migrations::v1::MigrateToV1`.
/// - v2: multi-tree forest — `SealedTreeRoots` / `SealedRootIndex`
/// (start empty; version-only bump in `migrations::v2::MigrateToV2`).
/// - v1: `MerkleNodes` (internal Merkle tree nodes), backfilled from `MerkleLeaves`.
/// - v2: multi-tree forest — `SealedTreeRoots` / `SealedRootIndex` (start empty).
///
/// The v1/v2 migration code was removed once every live chain reached v2; a new
/// chain starts here via genesis. See git history if an old chain ever needs it.
pub const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);

#[pallet::pallet]
Expand Down
193 changes: 0 additions & 193 deletions frame/shielded-pool/src/migrations.rs
View file
Open in desktop

This file was deleted.

11 changes: 10 additions & 1 deletion frame/zk-verifier/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,16 @@ All notable changes to this pallet are documented here.

---

## [Unreleased]
## [0.11.0] - 2026-08-04

### Removed
- **`migrations` module.** Every live chain is at storage version v1 (verified
on-chain against testnet at block 283941) and a fresh chain starts there via
genesis, so `MigrateToV1` was a no-op guarded by its version check. Removed
alongside the shielded-pool migrations. Storage version history stays
documented on `STORAGE_VERSION`; see git history if an old chain ever needs
the code. `STORAGE_VERSION` itself is unchanged (still v1) — this removes the
upgrade path, not the on-chain layout.

---

Expand Down
2 changes: 1 addition & 1 deletion frame/zk-verifier/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pallet-zk-verifier"
version = "0.10.0"
version = "0.11.0"
description = "Zero-Knowledge proof verification pallet for Orbinum"
authors = ["Orbinum Team"]
license = "GPL-3.0-or-later"
Expand Down
7 changes: 4 additions & 3 deletions frame/zk-verifier/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ extern crate alloc;
pub use pallet::*;

mod encoding;
pub mod migrations;
mod port;
mod runtime_api;
mod types;
Expand Down Expand Up @@ -52,8 +51,10 @@ pub mod pallet {
use frame_system::pallet_prelude::*;

/// Storage version history:
/// - v1: drop the retired `private_link` circuit (id 5), cleared by
/// `migrations::v1::MigrateToV1`.
/// - v1: drop the retired `private_link` circuit (id 5).
///
/// The v1 migration code was removed once every live chain reached v1; a new chain
/// starts here via genesis. See git history if an old chain ever needs it.
pub const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);

#[pallet::pallet]
Expand Down
Loading
Loading