fix: show actual debug upstream format - #110
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 94.77% 94.81% +0.03%
==========================================
Files 21 21
Lines 4251 4278 +27
Branches 1238 1249 +11
==========================================
+ Hits 4029 4056 +27
Misses 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a64e505cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (upstreamRequest?.url.endsWith('/responses')) return 'OpenAI Responses'; | ||
| return 'OpenAI Chat'; |
There was a problem hiding this comment.
Handle absent upstream requests without claiming Chat
When a request fails before an upstream call—such as /v1/messages with no messages—the finalized trace retains upstreamRequest: null, but this fallback labels both upstream sections as OpenAI Chat. That makes the diagnostic UI claim a protocol that was never used; return an unknown/not-sent format for null requests instead.
Useful? React with 👍 / 👎.
Summary
content_block_deltatext events so transformed responses show their content.Validation
bun run lintbun run format:checkbun run typecheckbun run test:coverage(244 tests passed; 93.81% statement coverage)bun run buildis blocked in the sandbox because Turbopack cannot bind a port.