fix: invoke_oci_api fails for LogSearchClient.search_logs bug#362
Open
dustin-sale wants to merge 1 commit into
Open
fix: invoke_oci_api fails for LogSearchClient.search_logs bug#362dustin-sale wants to merge 1 commit into
dustin-sale wants to merge 1 commit into
Conversation
dustin-sale
requested review from
AlaaShaker,
gebhardtr and
krisrice
as code owners
July 10, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
invoke_oci_apipagination for OCI responses that expose records throughresults, includingoci.loggingsearch.LogSearchClient.search_logs.The generic OCI SDK paginator assumes non-list response models expose
items, which causedSearchResponse.resultscalls to fail. This change uses the server’s response-shape-aware pagination loop for bounded and unbounded requests, preserves DNS/Object Storage handling, and retains unbounded SDKlimitpass-through semantics.Dependencies: none.
Fixes #356
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make lintmake test project=oci-cloud-mcp-server— 199 passed; 91.75% coverageLogSearchClient.search_logscalls against the supplied Phoenix log group, covering emptySearchResponse.resultsfor bounded and unbounded pathsTest Configuration:
Checklist: