Agent Spec Evaluation Computer improvements - #240
Open
soufianeamini wants to merge 1 commit into
Open
Conversation
soufianeamini
commented
Aug 27, 2026
Member
- Use CapacityLimiter over Semaphore
- Limit the amount of concurrent tasks that are running at once (the number of tasks spawned would be at most max_concurrency + 1)
- Producer/worker pattern is not needed anymore as a result
soufianeamini
commented
Aug 27, 2026
Member
Author
There was a problem hiding this comment.
@cesarebernardis The test_unlimited_concurrency test fails if the tasks finish too soon (if I add a bigger delay it succeeds) because it is not required anymore that all tasks start before starting processing. So from testing instead of seeing tasks go up to 200 running tasks concurrently, it ends up hovering around the 60 concurrent tasks range.
Is there a different kind of test you'd want to be implemented or should I just delete it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.