Repository navigation
[SE-711] Scan whole page in remaining axe specs - #26115
Merged
Merged
Conversation
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
lwassermann
approved these changes
Oct 21, 2026
lwassermann
left a comment
Contributor
There was a problem hiding this comment.
👍 🟢
Thank you for the explanation. I think I'd have accepted it anyway under the assumption that something outside the content is now fixed 😄
Base automatically changed from
feature/se-659-audit-pages-with-axe-scan
to
dev
October 22, 2026 11:44
Seven feature specs written before the axe audit still scoped their scan to #content to dodge the modal overlay focus trap. With the trap disabled while no modal is open (SE-710), the scan now covers the whole page, including header, sidebar and global menus. https://community.openproject.org/wp/SE-711
myabc
force-pushed
the
feature/se-711-whole-page-axe-scans
branch
from
October 22, 2026 12:58
8604644 to
c821563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on #25846. Please review/merge that PR first.
Ticket
https://community.openproject.org/wp/SE-711
What are you trying to accomplish?
Seven feature specs written before the axe audit still scope their scan to
#content: documents index, storages admin index, wiki internal provider, admin LLM connection, and the three SCIM client specs. The scoping dodged the modal overlay focus trap, which SE-710 (#25846) disables while no modal is open. Header, sidebar and global menus on those pages were never scanned.This drops the scoping so the scan covers the whole page. No
be_axe_clean.within("#content")is left underspec/ormodules/*/spec/.What approach did you choose and why?
Same change as the whole-page commit on #25846, applied to the remaining specs. Stacked on #25846 because it depends on the focus-trap fix there. Any chrome-level violation the wider scan surfaces is fixed on this branch; CI is the first full run, since axe needs Selenium.
AI involvement
Directed – AI did the mechanical edit from my brief; I reviewed every line.
Merge checklist