Skip to content

[SE-711] Scan whole page in remaining axe specs - #26115

Merged
myabc merged 1 commit into
devfrom
feature/se-711-whole-page-axe-scans
Oct 22, 2026
Merged

myabc merged 1 commit into
devfrom
feature/se-711-whole-page-axe-scans

Conversation

@myabc

@myabc myabc commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Note

This PR is stacked on #25846. Please review/merge that PR first.

Ticket

https://community.openproject.org/wp/SE-711

What are you trying to accomplish?

Seven feature specs written before the axe audit still scope their scan to #content: documents index, storages admin index, wiki internal provider, admin LLM connection, and the three SCIM client specs. The scoping dodged the modal overlay focus trap, which SE-710 (#25846) disables while no modal is open. Header, sidebar and global menus on those pages were never scanned.

This drops the scoping so the scan covers the whole page. No be_axe_clean.within("#content") is left under spec/ or modules/*/spec/.

What approach did you choose and why?

Same change as the whole-page commit on #25846, applied to the remaining specs. Stacked on #25846 because it depends on the focus-trap fix there. Any chrome-level violation the wider scan surfaces is fixed on this branch; CI is the first full run, since axe needs Selenium.

AI involvement

Directed – AI did the mechanical edit from my brief; I reviewed every line.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, components, etc.)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@github-actions github-actions Bot added the ai: Directed 🪄 A human specified the requirements and AI implemented most of it; They validated via testing. label Oct 18, 2026
@myabc
myabc added this pull request to stack #26116 October 18, 2026 15:14
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/work_packages/details/relations/primerized_relations_syncing_spec.rb[1:2]
  • rspec ./spec/features/work_packages/table/queries/id_filter_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #26115, linked for reference only):

- `rspec ./spec/features/work_packages/details/relations/primerized_relations_syncing_spec.rb[1:2]`
- `rspec ./spec/features/work_packages/table/queries/id_filter_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #26115. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #26115 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @myabc to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @myabc, and request a review from @myabc.
On every commit, set @myabc as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@myabc
myabc marked this pull request as ready for review October 18, 2026 15:36
@myabc
myabc requested a review from a team October 18, 2026 15:39
@myabc myabc mentioned this pull request Oct 18, 2026
1 of 3 tasks

@lwassermann lwassermann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🟢
Thank you for the explanation. I think I'd have accepted it anyway under the assumption that something outside the content is now fixed 😄

Base automatically changed from feature/se-659-audit-pages-with-axe-scan to dev October 22, 2026 11:44
Seven feature specs written before the axe audit still scoped their
scan to #content to dodge the modal overlay focus trap. With the trap
disabled while no modal is open (SE-710), the scan now covers the
whole page, including header, sidebar and global menus.

https://community.openproject.org/wp/SE-711
@myabc
myabc force-pushed the feature/se-711-whole-page-axe-scans branch from 8604644 to c821563 Compare October 22, 2026 12:58
@myabc
myabc merged commit 8ccf04c into dev Oct 22, 2026
16 of 17 checks passed
@myabc
myabc deleted the feature/se-711-whole-page-axe-scans branch October 22, 2026 14:44
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Accessibility ai: Directed 🪄 A human specified the requirements and AI implemented most of it; They validated via testing. needs review Passion time

Development

Successfully merging this pull request may close these issues.

2 participants