Repository navigation
Wait for typed value in progress preview spec - #26111
Merged
Merged
Conversation
Clearing the input fires an input event that schedules the 100ms debounced preview. When typing starts later than that, as on slow WebKit CI runners, a preview with an empty value sets the frame src first and the spec reads its params before the typed value arrives. Moves the value assertion into waitFor so the spec waits for the preview request carrying the typed value.
github-actions
Bot
added
the
ai: Collaborative 💻
myabc
marked this pull request as ready for review
October 16, 2026 15:44
|
Warning This pull request does not link an OpenProject work package. Please add a link to the work package in the description, or reference it in the |
myabc
added
flaky-spec
oliverguenther
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
None. Flaky failure seen on WebKit: https://github.com/opf/openproject/actions/runs/38923713176/job/117049852772
Relates to #25168
What are you trying to accomplish?
Fixes a race in the progress preview controller spec "sends the touched fields with the preview request".
What approach did you choose and why?
userEvent.clearfires aninputevent that schedules the 100 ms debounced preview. When typing starts later than that, as on slow WebKit runners, a preview with an empty value sets the framesrcfirst, and the spec read its params before the typed value arrived (expected '' to be '12').The value assertion now sits inside
waitFor, so the spec waits for the preview request carrying the typed value. Forcing a 150 ms gap between clear and type reproduces the CI failure with the old spec; the new spec passes.AI involvement
Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.
Merge checklist