Skip to content

[SE-635] Upgrade/revive the Forums module - #25872

Merged
dfriquet merged 55 commits into
devfrom
epic/se-635-revive-the-forums-module
Oct 19, 2026
Merged

dfriquet merged 55 commits into
devfrom
epic/se-635-revive-the-forums-module

Conversation

@dfriquet

@dfriquet dfriquet commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/SE-635

What are you trying to accomplish?

Collects the stacked pull requests of the Forums revival side project. Its own code is the development seed data the stack shares; each stacked pull request merges into this branch.

Stacked pull requests:

What approach did you choose and why?

  • Base branch of every Forums revival pull request; it goes to dev once the stack is complete.
  • Its commit seeds a dev-forums development project with forums and topics of every kind, for trying out the stacked pull requests.

AI involvement

Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@github-actions github-actions Bot added the ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. label Oct 7, 2026
@dfriquet
dfriquet added this pull request to stack #25875 October 7, 2026 14:51
@dfriquet
dfriquet removed this pull request from stack #25875 October 8, 2026 09:17
@dfriquet
dfriquet force-pushed the epic/se-635-revive-the-forums-module branch 4 times, most recently from 8bb46f0 to f798d00 Compare October 9, 2026 16:17
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/notifications/navigation_spec.rb[1:1:1]
  • rspec ./spec/features/types/form_configuration_query_spec.rb[1:1:9:1:1]
  • rspec ./spec/features/types/form_configuration_query_spec.rb[1:1:10:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25872, linked for reference only):

- `rspec ./spec/features/notifications/navigation_spec.rb[1:1:1]`
- `rspec ./spec/features/types/form_configuration_query_spec.rb[1:1:9:1:1]`
- `rspec ./spec/features/types/form_configuration_query_spec.rb[1:1:10:1:1]`

Treat this as a standalone task, unrelated to PR #25872. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25872 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @dfriquet to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @dfriquet, and request a review from @dfriquet.
On every commit, set @dfriquet as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

oliverguenther
oliverguenther previously approved these changes Oct 13, 2026
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/resource_management/spec/features/work_package_allocated_time_field_spec.rb[1:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25872, linked for reference only):

- `rspec ./modules/resource_management/spec/features/work_package_allocated_time_field_spec.rb[1:2]`

Treat this as a standalone task, unrelated to PR #25872. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25872 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @dfriquet to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @dfriquet, and request a review from @dfriquet.
On every commit, set @dfriquet as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@dfriquet
dfriquet marked this pull request as ready for review October 19, 2026 07:00
@dfriquet
dfriquet force-pushed the epic/se-635-revive-the-forums-module branch from 0a6b11c to 9cb9f1f Compare October 19, 2026 07:00
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/backlogs/spec/features/backlogs/start_finish_spec.rb[1:2:2:3]
  • rspec ./modules/resource_management/spec/features/edit_resource_allocation_assignee_spec.rb[1:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25872, linked for reference only):

- `rspec ./modules/backlogs/spec/features/backlogs/start_finish_spec.rb[1:2:2:3]`
- `rspec ./modules/resource_management/spec/features/edit_resource_allocation_assignee_spec.rb[1:1:1]`

Treat this as a standalone task, unrelated to PR #25872. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25872 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @dfriquet to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @dfriquet, and request a review from @dfriquet.
On every commit, set @dfriquet as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@dfriquet
dfriquet merged commit 1739870 into dev Oct 19, 2026
26 of 27 checks passed
@dfriquet
dfriquet deleted the epic/se-635-revive-the-forums-module branch October 19, 2026 07:47
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. Passion time

Development

Successfully merging this pull request may close these issues.

2 participants