drop all sqlite support (and channel priority properties) by grokspawn · Pull Request #1986 · operator-framework/operator-registry

grokspawn · 2026-05-15T14:58:13Z

Description of the change:
A view of how opm would look if we drop all SQLite support (which has been deprecated for 4+ years).
This also drops the channel priority property, which was an alpha, internal implementation that never proved worthwhile.

Motivation for the change:

Reviewer Checklist

Implementation matches the proposed design, or proposal is updated to match implementation
Sufficient unit test coverage
Sufficient end-to-end test coverage
Docs updated or added to /docs
Commit messages sensible and descriptive

openshift-ci · 2026-05-15T14:58:17Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-05-15T14:58:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

Pull request overview

This PR removes the long-deprecated SQLite-based catalog/index path from operator-registry and drops the (internal/alpha) channel priority property support, leaving the file-based catalog (FBC / declarative config) path as the supported workflow.

Changes:

Remove SQLite implementation code, migrations, testdata, and sqlite-backed CLI surfaces (opm index, opm registry, standalone servers, sqlite migration command).
Remove channel priority property construction in the alpha property layer.
Adjust build configuration/dependencies to reflect the removal (tags/CGO changes, module dependency cleanup).

Reviewed changes

Copilot reviewed 115 out of 163 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/e2e/opm_test.go	Removes sqlite/indexer imports (but file still contains sqlite/indexer usages; currently breaks compilation).
pkg/sqlite/testdata/test_db_migrations/valid/200412250000_fake_migration.up.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/valid/200412250000_fake_migration.down.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/valid/200112250000_fake_migration.up.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/valid/200112250000_fake_migration.down.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/invalid/randomscript.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/strandedbundles/prometheus.0.22.2/metadata/dependencies.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.22.2/metadata/annotations.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.22.2/manifests/prometheusrule.crd.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.15.0/metadata/annotations.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.15.0/manifests/prometheusrule.crd.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.14.0/metadata/annotations.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.14.0/manifests/prometheusrule.crd.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/loader_data/prometheus/prometheus.package.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.22.2/servicemonitor.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.22.2/prometheusrule.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.15.0/servicemonitor.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.15.0/prometheusrule.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.14.0/prometheusrule.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/etcd.package.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.9.2/etcdrestore.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.9.2/etcdcluster.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.9.2/etcdbackup.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.6.1/etcdcluster.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/3scale-community-operator.package.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/tenants.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/plans.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/metrics.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/mappingrules.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/limits.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/bindings.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/apimanagers.apps.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/.gitignore	Removes sqlite testdata ignore rules.
pkg/sqlite/stranded.go	Removes sqlite stranded bundle remover implementation.
pkg/sqlite/stranded_test.go	Removes sqlite stranded bundle remover tests.
pkg/sqlite/sqlitefakes/fake_rowscanner.go	Removes generated fakes tied to sqlite interfaces.
pkg/sqlite/sqlitefakes/fake_querier.go	Removes generated fakes tied to sqlite interfaces.
pkg/sqlite/remove.go	Removes sqlite package removal implementation.
pkg/sqlite/remove_test.go	Removes sqlite package removal tests.
pkg/sqlite/migrator.go	Removes sqlite migrator implementation.
pkg/sqlite/migrations/migrations.go	Removes sqlite migrations registry/types.
pkg/sqlite/migrations/013_rm_truncated_deprecations.go	Removes sqlite migration.
pkg/sqlite/migrations/013_rm_truncated_deprecations_test.go	Removes sqlite migration test.
pkg/sqlite/migrations/012_deprecated.go	Removes sqlite migration.
pkg/sqlite/migrations/012_deprecated_test.go	Removes sqlite migration test.
pkg/sqlite/migrations/011_susbtitutes_for.go	Removes sqlite migration.
pkg/sqlite/migrations/010_set_bundlepath_pkg_property.go	Removes sqlite migration.
pkg/sqlite/migrations/009_properties.go	Removes sqlite migration.
pkg/sqlite/migrations/008_dependencies.go	Removes sqlite migration.
pkg/sqlite/migrations/007_replaces_skips.go	Removes sqlite migration.
pkg/sqlite/migrations/005_version_skiprange.go	Removes sqlite migration.
pkg/sqlite/migrations/003_required_apis.go	Removes sqlite migration.
pkg/sqlite/migrations/002_bundle_path.go	Removes sqlite migration.
pkg/sqlite/migrations/002_bundle_path_test.go	Removes sqlite migration test.
pkg/sqlite/migrations/001_related_images.go	Removes sqlite migration.
pkg/sqlite/migrations/000_init.go	Removes sqlite schema initialization migration.
pkg/sqlite/loadprocs.go	Removes sqlite loader helper procedures.
pkg/sqlite/graphloader.go	Removes sqlite graph loader implementation.
pkg/sqlite/graphloader_test.go	Removes sqlite graph loader tests.
pkg/sqlite/directory.go	Removes sqlite directory loader implementation.
pkg/sqlite/deprecationmessage.go	Removes sqlite deprecation message helper.
pkg/sqlite/deprecate.go	Removes sqlite deprecate/truncate logic.
pkg/sqlite/db.go	Removes sqlite DB open helpers and driver import.
pkg/sqlite/db_options.go	Removes sqlite DB options.
pkg/sqlite/conversion.go	Removes sqlite->model conversion path.
pkg/sqlite/conversion_test.go	Removes sqlite conversion tests.
pkg/sqlite/configmap.go	Removes sqlite configmap loader implementation.
pkg/mirror/options.go	Removes mirror options (tied to sqlite DB extraction path).
pkg/mirror/mirror.go	Removes index image mirroring implementation (sqlite DB driven).
pkg/mirror/mirror_test.go	Removes mirror tests.
pkg/lib/registry/registryfakes/fake_registry_deleter.go	Removes generated fakes for sqlite registry updater flow.
pkg/lib/registry/registryfakes/fake_registry_adder.go	Removes generated fakes for sqlite registry updater flow.
pkg/lib/registry/interfaces.go	Removes registry updater interfaces used by sqlite registry commands.
pkg/lib/indexer/testdata/package.yaml	Removes indexer testdata.
pkg/lib/indexer/interfaces.go	Removes indexer interfaces (sqlite-based index command plumbing).
pkg/lib/indexer/indexerfakes/fake_index_exporter.go	Removes generated fakes for indexer.
pkg/lib/indexer/indexerfakes/fake_index_deleter.go	Removes generated fakes for indexer.
pkg/lib/indexer/indexerfakes/fake_index_adder.go	Removes generated fakes for indexer.
pkg/lib/indexer/indexer_test.go	Removes indexer tests.
Makefile	Drops sqlite-related build tag; changes cross-build to CGO disabled.
go.mod	Removes direct sqlite-related deps, but still includes `go-sqlite3` indirectly (may need cleanup).
cmd/registry-server/main.go	Removes deprecated standalone sqlite registry server binary.
cmd/opm/root/cmd.go	Removes `opm index`, `opm registry`, and `opm migrate` from root command.
cmd/opm/render/cmd.go	Removes sqlite from `opm render` help/behavior.
cmd/opm/registry/serve.go	Removes sqlite-backed `opm registry serve`.
cmd/opm/registry/rm.go	Removes sqlite-backed `opm registry rm`.
cmd/opm/registry/prunestranded.go	Removes sqlite-backed `opm registry prune-stranded`.
cmd/opm/registry/prune.go	Removes sqlite-backed `opm registry prune`.
cmd/opm/registry/mirror.go	Removes unused mirror command (sqlite-based).
cmd/opm/registry/deprecatetruncate.go	Removes sqlite-backed deprecate/truncate command.
cmd/opm/registry/cmd.go	Removes `opm registry` command group.
cmd/opm/registry/add.go	Removes sqlite-backed `opm registry add`.
cmd/opm/migrate/cmd.go	Removes sqlite->FBC migration command.
cmd/opm/index/prunestranded.go	Removes sqlite-backed `opm index prune-stranded`.
cmd/opm/index/prune.go	Removes sqlite-backed `opm index prune`.
cmd/opm/index/export.go	Removes sqlite-backed `opm index export`.
cmd/opm/index/deprecatetruncate.go	Removes sqlite-backed `opm index deprecatetruncate`.
cmd/opm/index/delete.go	Removes sqlite-backed `opm index rm`.
cmd/opm/index/cmd.go	Removes `opm index` command group.
cmd/opm/alpha/render-graph/cmd.go	Removes sqlite refs from alpha render-graph allowed ref set.
cmd/initializer/main.go	Removes deprecated initializer binary (manifests -> sqlite DB).
cmd/configmap-server/main.go	Removes configmap-server (configmap -> sqlite DB -> gRPC).
alpha/property/property.go	Drops channel priority property fields/builders.
alpha/action/render.go	Removes sqlite rendering support; now only supports declcfg images/dirs and bundles.
alpha/action/migrate.go	Disallows migrating sqlite refs (only declcfg image/dir).
alpha/action/migrate_test.go	Skips sqlite migration tests.
alpha/action/list.go	Disallows listing via sqlite refs (only declcfg image/dir).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 	"github.com/operator-framework/operator-registry/pkg/registry"
-	"github.com/operator-framework/operator-registry/pkg/sqlite"
 )


 // checkDBFile returns an error if ref is not an sqlite3 database.
-func checkDBFile(ref string) error {
-	typ, err := filetype.MatchFile(ref)
-	if err != nil {
-		return err
-	}
-	if typ != matchers.TypeSqlite {
-		return fmt.Errorf("ref %q has unsupported file type: %s", ref, typ)
-	}
-	return nil
-}
-
-func sqliteToDeclcfg(ctx context.Context, db *sql.DB) (*declcfg.DeclarativeConfig, error) {
-	logDeprecationMessage.Do(func() {
-		sqlite.LogSqliteDeprecation()
-	})
-
-	migrator, err := sqlite.NewSQLLiteMigrator(db)
-	if err != nil {
-		return nil, err
-	}
-	if migrator == nil {
-		return nil, fmt.Errorf("failed to load migrator")
-	}
-
-	if err := migrator.Migrate(ctx); err != nil {
-		return nil, err
-	}
-
-	q := sqlite.NewSQLLiteQuerierFromDb(db)
-	m, err := sqlite.ToModel(ctx, q)
-	if err != nil {
-		return nil, err
-	}
-
-	cfg := declcfg.ConvertFromModel(m)
-
-	if err := populateDBRelatedImages(ctx, &cfg, db); err != nil {
-		return nil, err
-	}
-
-	return &cfg, nil
-}
-
-func populateDBRelatedImages(ctx context.Context, cfg *declcfg.DeclarativeConfig, db *sql.DB) error {
-	rows, err := db.QueryContext(ctx, "SELECT image, operatorbundle_name FROM related_image")
-	if err != nil {
-		return err
-	}
-	defer rows.Close()
-
-	// nolint:staticcheck
-	images := map[string]sets.String{}
-	for rows.Next() {
-		var (
-			img        sql.NullString
-			bundleName sql.NullString
-		)
-		if err := rows.Scan(&img, &bundleName); err != nil {
-			return err
-		}
-		if !img.Valid || !bundleName.Valid {
-			continue
-		}
-		m, ok := images[bundleName.String]
-		if !ok {
-			m = sets.NewString()
-		}
-		m.Insert(img.String)
-		images[bundleName.String] = m
-	}
-
-	for i, b := range cfg.Bundles {
-		ris, ok := images[b.Name]
-		if !ok {
-			continue
-		}
-		for _, ri := range b.RelatedImages {
-			if ris.Has(ri.Image) {
-				ris.Delete(ri.Image)
-			}
-		}
-		for ri := range ris {
-			cfg.Bundles[i].RelatedImages = append(cfg.Bundles[i].RelatedImages, declcfg.RelatedImage{Image: ri})
-		}
-	}
-	return nil
-}



-	github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/mattn/go-runewidth v0.0.19 // indirect
+	github.com/mattn/go-sqlite3 v1.14.32 // indirect


codecov · 2026-05-15T15:03:01Z

Codecov Report

❌ Patch coverage is 54.31711% with 291 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.22%. Comparing base (7d2bc9b) to head (6125a0a).

Files with missing lines	Patch %	Lines
alpha/declcfg/api_conversions.go	33.59%	163 Missing and 9 partials ⚠️
alpha/declcfg/validate.go	41.66%	44 Missing and 19 partials ⚠️
alpha/action/list.go	86.55%	5 Missing and 11 partials ⚠️
pkg/cache/pkgs.go	78.12%	7 Missing and 7 partials ⚠️
alpha/action/render.go	61.29%	11 Missing and 1 partial ⚠️
pkg/cache/cache.go	65.21%	4 Missing and 4 partials ⚠️
alpha/action/init.go	91.30%	2 Missing ⚠️
alpha/declcfg/image_validation.go	66.66%	1 Missing and 1 partial ⚠️
alpha/template/substitutes/substitutes.go	50.00%	0 Missing and 1 partial ⚠️
pkg/lib/config/validate.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
- Coverage   57.86%   52.22%   -5.65%     
==========================================
  Files         140       95      -45     
  Lines       13448     7920    -5528     
==========================================
- Hits         7782     4136    -3646     
+ Misses       4475     3234    -1241     
+ Partials     1191      550     -641

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 111 out of 170 changed files in this pull request and generated 3 comments.

 	"github.com/operator-framework/operator-registry/pkg/registry"
-	"github.com/operator-framework/operator-registry/pkg/sqlite"
 )


 	github.com/json-iterator/go v1.1.12 // indirect
 	github.com/klauspost/compress v1.18.4 // indirect
 	github.com/klauspost/pgzip v1.2.6 // indirect
-	github.com/liggitt/tabwriter v0.0.0-20181228230101-89fcab3d43de // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/mattn/go-runewidth v0.0.19 // indirect
+	github.com/mattn/go-sqlite3 v1.14.32 // indirect
 	github.com/miekg/pkcs11 v1.1.2 // indirect


 		Long: `Generate a stream of file-based catalog objects to stdout from the provided
-catalog images, file-based catalog directories, bundle images, and sqlite
-database files.
+catalog images, file-based catalog directories, and bundle images.


Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Signed-off-by: grokspawn <jordan@nimblewidget.com>

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings May 15, 2026 14:58

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2026

Copilot started reviewing on behalf of grokspawn May 15, 2026 14:58 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

grokspawn force-pushed the proto-v2 branch from 87c3383 to e7e295d Compare May 15, 2026 15:28

Copilot AI review requested due to automatic review settings May 15, 2026 15:48

grokspawn force-pushed the proto-v2 branch from e7e295d to 9933bd6 Compare May 15, 2026 15:48

Copilot started reviewing on behalf of grokspawn May 15, 2026 15:49 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 15, 2026 18:50

grokspawn force-pushed the proto-v2 branch from 1497b3d to 5eb3a04 Compare May 15, 2026 18:50

Copilot AI reviewed May 15, 2026

View reviewed changes

grokspawn force-pushed the proto-v2 branch from 5eb3a04 to 10e615b Compare May 15, 2026 20:44

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2026

Copilot AI review requested due to automatic review settings May 18, 2026 14:56

grokspawn force-pushed the proto-v2 branch from 10e615b to faecf8d Compare May 18, 2026 14:56

Copilot AI reviewed May 18, 2026

View reviewed changes

drop all sqlite support (and channel priority properties)

0b69e6e

grokspawn force-pushed the proto-v2 branch from faecf8d to cf9b120 Compare May 18, 2026 15:04

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2026

relocate all model functionality to declcfg and eliminate model package

6125a0a

Signed-off-by: grokspawn <jordan@nimblewidget.com>

grokspawn force-pushed the proto-v2 branch from cf9b120 to 6125a0a Compare May 18, 2026 15:05

Copilot AI review requested due to automatic review settings May 18, 2026 15:05

Copilot AI reviewed May 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop all sqlite support (and channel priority properties)#1986

drop all sqlite support (and channel priority properties)#1986
grokspawn wants to merge 2 commits into
operator-framework:masterfrom
grokspawn:proto-v2

grokspawn commented May 15, 2026

Uh oh!

openshift-ci Bot commented May 15, 2026

Uh oh!

openshift-ci Bot commented May 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codecov Bot commented May 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

grokspawn commented May 15, 2026

Uh oh!

openshift-ci Bot commented May 15, 2026

Uh oh!

openshift-ci Bot commented May 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codecov Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented May 15, 2026 •

edited

Loading