snmpd-openwrt-metrics: add new package by perceival · Pull Request #30547 · openwrt/packages

perceival · 2026-09-16T16:36:39Z

📦 Package Details

Maintainer: @perceival

Description:

Stock OpenWrt reports nothing useful about its wireless side or its sensors over SNMP: the ieee802dot11 MIB module produces no data on mac80211 drivers, and net-snmp's lmSensors module can't be enabled because it still targets the libsensors 2 API that lm-sensors 3 removed.

This adds a small AgentX subagent that serves three subtrees under OpenWrt's own IANA enterprise number (66510) and the standard LM-SENSORS-MIB arc: device metadata (OpenWrt release, build revision, target and model, so a manager can identify the device without extend scripts), a per-interface wireless table (clients, frequency, noise floor, tx/rx rate range, SNR range, channel utilisation, tx power, indexed by ifIndex so it joins IF-MIB) plus a per-radio-link table for 802.11be Multi-Link Operation interfaces (which have no single value for those columns), and hwmon/thermal-zone temperature and fan readings. Wireless data comes from libiwinfo, MLO per-link data from a direct nl80211 query (libiwinfo has no MLO awareness), and sensor data from the union of hwmon and thermal zones. No snmpd configuration is required — the AgentX master is on by default.

OPENWRT-MIB also defines openwrtDevice (.1.3.6.1.4.1.66510.3.1) as a sysObjectID value for snmpd to report, so a manager can recognise an OpenWrt device without querying anything extra. Setting it is left to snmpd's own config, not done by this package.

This is the device-side implementation for LibreNMS PR librenms/librenms#19347, replacing the shell pass_persist script that PR originally described.

🧪 Run Testing Details

OpenWrt Version: SNAPSHOT
OpenWrt Target/Subtarget: qualcommbe/ipq53xx (primary hardware target), ipq806x/generic (cross-architecture build verification)
OpenWrt Device: GL.iNet GL-BE9300 (Flint 3) ×2 (one an 802.11be multi-link 5GHz+6GHz AP), Netgear Nighthawk X4S R7800

Verified on all three: --version/-V/--help, a full SNMP walk of both MIB tables against each device's real snmpd (via snmpwalk), and (on the two Flint 3 units) that the multi-link interface's per-link table matches iw dev <iface> info exactly while the main interface table correctly reports its radio-scoped columns as absent rather than a misleading single value. On the R7800 (no 802.11be hardware) confirmed the link table is genuinely absent rather than present-but-empty.

The device metadata scalars were verified on the R7800 against that device's own /etc/os-release and /tmp/sysinfo/model, including that a walk passes through them into the wireless subtree and that a field the device does not provide is simply not instantiated. Setting option sysObjectID in snmpd's config was confirmed to make snmpd report it.

✅ Formalities

I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

N/A — this is a new package, not a patch.

openwrt · 2026-09-16T16:36:45Z

Formality Check: Suggestions Available

We checked this pull request against the contribution guidelines. Here is what needs your attention:

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Commit cecd716:

⚠️ Incorrect capitalization of 'OpenWrt' detected: 'OPENWRT'. Please use the correct spelling 'OpenWrt' (or lowercase 'openwrt' where appropriate).

_{Something broken? Consider reporting an issue.}
_{Running version 37cc78e deployed on 2026-10-15 12:36:36 CEST}

openwrt-ai

Reviewed 1 new commit.

Generated by Claude Code

perceival · 2026-09-17T09:53:36Z

The build succeeds on every architecture here. The two failing CI jobs (x86_64, arm_cortex-a15_neon-vfpv4) are dying in the post-build Docker runtime smoke test, at apk update inside the container — wget: exited with error 8 fetching https://downloads.openwrt.org/snapshots/targets/x86/64/kmods/.../packages.adb (note the slash between x86 and 64, should be x86_64 like every other URL in the same log). Same two jobs are failing the same way right now on #30544, which has nothing to do with this package, so it looks like a CI infrastructure issue rather than something in this PR.

openwrt-ai

Reviewed 1 new commit; no new issues found.

Generated by Claude Code

openwrt-ai

Reviewed 1 new commit.

Generated by Claude Code

openwrt-ai

Reviewed 1 new commit.

Generated by Claude Code

Both MIB files had drifted from openwrt/packages#30547's copies, which picked up a new openwrtWirelessLinkTable (per-link MLO metrics), the pass_persist->AgentX rename, and broadened noSuchInstance semantics on several columns since this PR last touched them. Re-synced from the packages source of truth; both still smilint -l 6 clean. Openwrt.php's WL_ENTRY comment still called the device-side agent a "pass_persist handler" - same stale wording, fixed to "AgentX subagent". The device note documented installing shell scripts (openwrt-snmp-pass.sh, lm-sensors-pass.sh) that don't exist in librenms-agent - that implementation's PR (librenms-agent#613) was closed once the native package proved out, and only fragments of the old per-script approach remain there. Rewritten to state the two MIB subtrees this PR actually depends on and point at the native package as the reference implementation, without prescribing an install method - matches this PR's own description ("doesn't depend on any particular way of getting them there") and drops the version-specific install/troubleshooting steps laf asked to avoid on this same page in 2026-06. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TDZtSTSfXU8FJqs1cXGPSY

openwrt-ai

Reviewed 1 new commit; no new issues found.

Generated by Claude Code

openwrt-ai

Reviewed 1 new commit; no new issues found.

Generated by Claude Code

openwrt-ai

Reviewed 1 new commit.

Generated by Claude Code

openwrt-ai

Reviewed 1 new commit; no new issues found.

Generated by Claude Code

feckert

Small changes
Styling topics

feckert · 2026-10-16T07:14:07Z

+	# start first, that is not fatal: net-snmp's AgentX subagent retries
+	# the master connection on its own alarm-driven schedule
+	# (agentx_reopen_session in agentx/subagent.c). The enabled check just
+	# avoids starting when snmpd is off entirely.


This should go into the commit message. If the order of the startup sequence ever changes, no one will remember that the comment here needs to be updated. And then the comment is wrong.
If anything, the agent it self tries to reconnect only if it hasn't started yet.

Moved the ordering rationale out of the script and into the commit message ("Init ordering" paragraph), so the script no longer carries a comment that can go stale. Landed in e16b60b.

feckert · 2026-10-16T07:14:13Z

+	# the master connection on its own alarm-driven schedule
+	# (agentx_reopen_session in agentx/subagent.c). The enabled check just
+	# avoids starting when snmpd is off entirely.
+	/etc/init.d/snmpd enabled || return 0


A log message should be added so that we know why this did not start.

Added: when snmpd is not enabled the script now logs "snmpd is not enabled, not starting" via logger (daemon.notice, tag openwrt-snmp-agent). Checked on a Flint 3 with snmpd disabled: the line shows up in logread and no agent process is started. Landed in e16b60b.

feckert · 2026-10-16T07:14:54Z

+	/etc/init.d/snmpd enabled || return 0
+
+	procd_open_instance
+	procd_set_param command "$PROG" -f -x /var/run/agentx.sock


The socket can be changed via uci
https://github.com/openwrt/packages/blob/master/net/net-snmp/files/snmpd.init#L21

Good point, thanks. The init script now reads agentxsocket from the agentx section of /etc/config/snmpd (default /var/run/agentx.sock) and passes it to the agent with -x. Checked on a Flint 3 with the default and with a custom agentxsocket: the agent connects to the configured socket and the 1.3.6.1.4.1.66510 objects are served through snmpd. Landed in e16b60b.

feckert · 2026-10-16T07:16:21Z

Has this file been checked for syntax errors using a linter?

feckert · 2026-10-16T07:17:51Z

+
+#include "collect.h"
+
+#define AGENT_VERSION "1.0.0"


This should be provided via the Makefile. It's likely to be overlooked during an update.

feckert · 2026-10-16T07:25:37Z

The closing */ should go into a new line
And multi line comments should look like this.

/* ------------------------------------------------------------------ * <message> * ------------------------------------------------------------------ */

feckert · 2026-10-16T07:26:49Z

The closing */ should go into a new line
And multi line comments should look like this.

/* ------------------------------------------------------------------ * <message> * ------------------------------------------------------------------ */

feckert · 2026-10-16T07:32:31Z

+		} else if (!strcmp(argv[i], "--version") ||
+			  !strcmp(argv[i], "-V") ||
+			  !strcmp(argv[i], "--help")) {
+			printf("openwrt-snmp-agent " AGENT_VERSION "\n");


The name of the programm is available via argv[0]

Stock OpenWrt reports nothing useful about its wireless side or its sensors over SNMP. The ieee802dot11 MIB module is compiled into net-snmp but produces no data on mac80211 drivers, and net-snmp's lmSensors module cannot be enabled because it still targets the libsensors 2 API that lm-sensors 3 removed. Add a small AgentX subagent serving three subtrees: .1.3.6.1.4.1.66510.1.1 OPENWRT-MIB device metadata: release version, build revision, target and model, so a manager can identify the device without extend scripts .1.3.6.1.4.1.66510.1.10 OPENWRT-WIRELESS-MIB, under OpenWrt's own IANA enterprise number, indexed by ifIndex so rows join IF-MIB: clients, frequency, noise floor, tx/rx rate range, SNR range, channel utilisation, tx power, and (for 802.11be Multi-Link Operation interfaces, which have no single value for those columns) a separate per-radio-link table .1.3.6.1.4.1.2021.13.16 LM-SENSORS-MIB temperature and fan tables Wireless data comes from libiwinfo, MLO per-link data from a direct nl80211 query (libiwinfo has no MLO awareness), and sensor data from hwmon and thermal zones, taking the union of the two so a sensor with no thermal zone (an MDIO PHY die sensor, for example) is still reported. snmpd enables the AgentX master by default and listens on a known socket, so the package needs no snmpd configuration at all: no pass registration, no uci-defaults, no removal hook. If the socket was moved with the agentxsocket option of the snmpd agentx section, the init script reads it from there and passes it to the agent. Radios, VAPs and sensors are discovered at request time, so there is nothing per-interface to maintain either. The SSID of each interface is read from hostapd over ubus, with libiwinfo as the fallback, because libiwinfo returns no SSID for some VAPs on a tri-band phy. --dump also lists the temperature and fan sensors the agent finds, which is what to check when a device reports no LM-SENSORS data. Tested on a GL-BE9300 (qualcommbe/ipq53xx), including its 802.11be multi-link (5GHz+6GHz) AP, and cross-checked against `iwinfo`/`iw`/sysfs output and a live AgentX registration against snmpd with `snmpwalk`. OPENWRT-MIB also defines openwrtDevice (.1.3.6.1.4.1.66510.3.1) as a sysObjectID value for snmpd to report; setting it is left to snmpd's own config. Init ordering: the AgentX master lives in snmpd, which starts at START=99, the top of the two-digit range (rc.common's glob-based enable/disable needs two digits, see rc.common), so nothing can be ordered strictly after it. The agent therefore starts at START=95 and relies on net-snmp's AgentX subagent retrying the master connection on its own schedule (agentx_reopen_session in agentx/subagent.c). The init script only checks that snmpd is enabled and logs when it is not. If the startup order of the base system ever changes, this is the assumption to re-check. Signed-off-by: Kamil Bienkiewicz <perceivalpercy@gmail.com>

openwrt-ai

Reviewed 1 new commit; no new issues found.

Generated by Claude Code

openwrt Bot added Add package not following guidelines labels Sep 16, 2026

openwrt-ai reviewed Sep 17, 2026

View reviewed changes

perceival force-pushed the snmpd-openwrt-metrics-pr branch from 4a8286f to ea6f205 Compare September 17, 2026 07:38

openwrt Bot removed the not following guidelines label Sep 17, 2026

This was referenced Sep 17, 2026

OpenWrt: add temperature sensors and fix wireless sensor discovery - consolidated librenms/librenms#19347

Open

OpenWrt agent: add temperature sensors and harden wireless SNMP setup librenms/librenms-agent#613

Closed

openwrt-ai reviewed Sep 18, 2026

View reviewed changes

perceival force-pushed the snmpd-openwrt-metrics-pr branch from ea6f205 to 7c7fa76 Compare September 18, 2026 08:03

openwrt-ai reviewed Sep 19, 2026

View reviewed changes

Comment thread net/snmpd-openwrt-metrics/files/openwrt-snmp-agent.init Outdated

Comment thread net/snmpd-openwrt-metrics/src/mlo.c Outdated

Comment thread net/snmpd-openwrt-metrics/files/OPENWRT-WIRELESS-MIB Outdated

Comment thread net/snmpd-openwrt-metrics/files/OPENWRT-MIB

perceival force-pushed the snmpd-openwrt-metrics-pr branch from 7c7fa76 to f5073a0 Compare September 19, 2026 07:48

openwrt-ai reviewed Sep 20, 2026

View reviewed changes

Comment thread net/snmpd-openwrt-metrics/files/openwrt-snmp-agent.init Outdated

perceival force-pushed the snmpd-openwrt-metrics-pr branch from f5073a0 to 633e140 Compare September 20, 2026 15:44

openwrt-ai reviewed Sep 21, 2026

View reviewed changes

BKPepe force-pushed the snmpd-openwrt-metrics-pr branch from 633e140 to 5e6cd1f Compare September 21, 2026 06:05

openwrt-ai reviewed Sep 21, 2026

View reviewed changes

perceival force-pushed the snmpd-openwrt-metrics-pr branch from 5e6cd1f to 521d532 Compare September 22, 2026 17:42

openwrt-ai reviewed Sep 23, 2026

View reviewed changes

Comment thread net/snmpd-openwrt-metrics/src/agent.c

perceival force-pushed the snmpd-openwrt-metrics-pr branch 2 times, most recently from cd67a0f to 3b476e7 Compare October 15, 2026 13:04

openwrt-ai reviewed Oct 16, 2026

View reviewed changes

feckert reviewed Oct 16, 2026

View reviewed changes

perceival force-pushed the snmpd-openwrt-metrics-pr branch from 3b476e7 to e16b60b Compare October 17, 2026 00:50

perceival mentioned this pull request Oct 17, 2026

net-snmp: report OpenWrt's own sysObjectID by default #30796

Open

perceival force-pushed the snmpd-openwrt-metrics-pr branch from e16b60b to cecd716 Compare October 17, 2026 03:30

openwrt-ai reviewed Oct 17, 2026

View reviewed changes

Conversation

perceival commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Package Details

🧪 Run Testing Details

✅ Formalities

If your PR contains a patch:

Uh oh!

openwrt Bot commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Formality Check: Suggestions Available

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

perceival commented Sep 17, 2026

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openwrt-ai left a comment

Choose a reason for hiding this comment

Uh oh!

feckert left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openwrt-ai left a comment

perceival commented Sep 16, 2026 •

edited

Loading

openwrt Bot commented Sep 16, 2026 •

edited

Loading

feckert left a comment •

edited

Loading