openssh: make libfido2 dependency conditional on sk-helper#29579
Open
micpf wants to merge 1 commit into
Open
Conversation
The openssh-sk-helper package unconditionally depends on libfido2, which causes the build system to pull in libfido2 and its dependencies (libcbor, libudev) even when openssh-sk-helper is not selected. Use the PACKAGE_openssh-sk-helper:libfido2 conditional dependency pattern so libfido2 is only required when the sk-helper sub-package is actually selected. Signed-off-by: Michael Pfeifroth <michael.pfeifroth@westermo.com>
micpf
force-pushed
the
fix/openssh-sk-helper-optional-libfido2
branch
from
8202714 to
1c09355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openssh-sk-helper package unconditionally depends on libfido2, which causes the build system to pull in libfido2 and its dependencies (libcbor, libudev) even when openssh-sk-helper is not selected.
Use the
PACKAGE_openssh-sk-helper:libfido2conditional dependency pattern so libfido2 is only required when the sk-helper sub-package is actually selected.