kea: fix BOOST_STATIC_ASSERT use in src/lib/dns/rdataclass.cc#29577
Merged
commodo merged 2 commits intoMay 30, 2026
Conversation
Snapshot builds for i386_pentium-mmx (and presumably every other
target now that Boost 1.91 has been bumped in the feed) fail with::
src/lib/dns/rdataclass.cc:1401:5: error: 'BOOST_STATIC_ASSERT'
was not declared in this scope; did you mean
'BOOST_HAS_STATIC_ASSERT'?
1401 | BOOST_STATIC_ASSERT(sizeof(numdata_) ==
``BOOST_STATIC_ASSERT`` lives in ``<boost/static_assert.hpp>``. In
earlier Boost releases it was reachable through any number of
transitive includes pulled in by Kea's other DNS headers; in 1.91
those transitive paths have been pruned, so call sites must include
the declaring header explicitly. ``050-boost-static-assert.patch``
already does this for ``src/lib/log/logger_level_impl.cc``;
``src/lib/dns/rdataclass.cc`` uses the same macro at SOA::getMinimum()
to size-check ``numdata_`` and was missed.
Extend the existing patch with the matching include in rdataclass.cc.
Same fix shape as the earlier hunk; no behavioural change.
Build log:
https://downloads.openwrt.org/snapshots/faillogs/i386_pentium-mmx/packages/kea/
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Commit 1ea43c3 ("kea: fix kea-libs dependencies") replaced the direct +log4cplus dependency on kea-libs with the virtual name +log4cplus-any. With only one log4cplus implementation in the feed, nothing actually PROVIDES log4cplus-any other than the auto-generated "package name + -any" alias on log4cplus itself. apk treats `-any`-suffixed names as ambiguous virtuals that the admin must resolve explicitly, even when only one provider exists, and refuses to install: ERROR: unable to select packages: log4cplus-any (virtual): note: please select one of the 'provided by' packages explicitly provided by: log4cplus required by: kea-libs-3.0.2-r7[log4cplus-any] That bubbles up to every kea subpackage runtime test in CI (kea-admin, kea-ctrl, every kea-dhcp* and kea-hook-*) and fails the multi-arch test build with exit code 3. Switch back to +log4cplus directly; the +libstdcpp addition from that earlier commit stays — it was the genuinely useful part of the change. Bump PKG_RELEASE for the redo. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
commodo
force-pushed
the
kea-boost-static-assert-rdataclass
branch
from
d76dbc8 to
c6d5817
Compare
Contributor
Author
|
wow.... this got really complicated kea-shell is a python script... so, let's not linger too much on this; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @pprindeville
Description:
Snapshot builds for i386_pentium-mmx (and presumably every other target now that Boost 1.91 has been bumped in the feed) fail with::
src/lib/dns/rdataclass.cc:1401:5: error: 'BOOST_STATIC_ASSERT'
was not declared in this scope; did you mean
'BOOST_HAS_STATIC_ASSERT'?
1401 | BOOST_STATIC_ASSERT(sizeof(numdata_) ==
BOOST_STATIC_ASSERTlives in<boost/static_assert.hpp>. In earlier Boost releases it was reachable through any number of transitive includes pulled in by Kea's other DNS headers; in 1.91 those transitive paths have been pruned, so call sites must include the declaring header explicitly.050-boost-static-assert.patchalready does this forsrc/lib/log/logger_level_impl.cc;src/lib/dns/rdataclass.ccuses the same macro at SOA::getMinimum() to size-checknumdata_and was missed.Extend the existing patch with the matching include in rdataclass.cc. Same fix shape as the earlier hunk; no behavioural change.
Build log:
https://downloads.openwrt.org/snapshots/faillogs/i386_pentium-mmx/packages/kea/
🧪 Run Testing Details
✅ Formalities