Skip to content

treewide: add version check overrides#29428

Merged
GeorgeSapkin merged 11 commits into
openwrt:masterfrom
GeorgeSapkin:treewide-add-version-check-overrides
May 17, 2026
Merged

treewide: add version check overrides#29428
GeorgeSapkin merged 11 commits into
openwrt:masterfrom
GeorgeSapkin:treewide-add-version-check-overrides

Conversation

@GeorgeSapkin
Copy link
Copy Markdown
Member

Maintainer:

Description:

Add manual version checks or skip version checks where appropriate.

Depends on:


✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from ea0852b to 62b186d Compare May 11, 2026 17:13
@BKPepe BKPepe changed the title teewide: add version check overrides treewide: add version check overrides May 11, 2026
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from 7167cd9 to 140aeb6 Compare May 11, 2026 19:54
Comment thread lang/python/python-pyserial/test-version.sh Outdated
Comment thread lang/python/python-tabulate/test-version.sh Outdated
@danielfdickinson
Copy link
Copy Markdown
Contributor

Noticed a couple of typos and commented. Hope it helps.

@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch 7 times, most recently from 40fb9d6 to 4b5ff7c Compare May 13, 2026 19:22
@GeorgeSapkin GeorgeSapkin marked this pull request as ready for review May 13, 2026 19:25
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch 3 times, most recently from 5b493ce to e8fd3b2 Compare May 14, 2026 13:36
@GeorgeSapkin

This comment was marked as resolved.

@commodo

This comment was marked as resolved.

@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from e8fd3b2 to c380456 Compare May 15, 2026 12:26
@commodo
Copy link
Copy Markdown
Contributor

commodo commented May 16, 2026

Let's move erlang in a separate PR/list.

It looks like there are some older packaging issues there

@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from c380456 to 0a4eb58 Compare May 16, 2026 11:53
@commodo
Copy link
Copy Markdown
Contributor

commodo commented May 16, 2026

I've tried some of these commits on my PR.
#29438

Did not completely solve things.
But they are in master now

@GeorgeSapkin
Copy link
Copy Markdown
Member Author

Looks like more stuff needs overrides. I'll have a look.

Move existing version checks into override and add explicit package checks.

Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
Fixes: 12b01ba ("libcap-ng-bin: add test-version.sh to skip version check")
Signed-off-by: George Sapkin <george@sapk.in>
Add explicit ftdi_eeprom version and a matching version check override.

Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from 0a4eb58 to d5a129e Compare May 16, 2026 15:39
Add source packages and library to version check overrides.

Fixes: b5d3a38 ("python3: move version checks to override")
Signed-off-by: George Sapkin <george@sapk.in>
Fixes: ac212e0 ("python-pyserial: add hostbuild")
Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
Skip version checks as none of the executables seem to report their
versions.

Signed-off-by: George Sapkin <george@sapk.in>
Add version check override script.

Signed-off-by: George Sapkin <george@sapk.in>
Move existing version checks into override and add explicit package checks.

Signed-off-by: George Sapkin <george@sapk.in>
@GeorgeSapkin GeorgeSapkin force-pushed the treewide-add-version-check-overrides branch from d5a129e to 518668e Compare May 17, 2026 11:35
@GeorgeSapkin GeorgeSapkin merged commit 292671a into openwrt:master May 17, 2026
0 of 2 checks passed
@GeorgeSapkin GeorgeSapkin deleted the treewide-add-version-check-overrides branch May 17, 2026 11:35
@@ -0,0 +1,15 @@
#!/bin/sh

# shellckeck shell=busybox
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is shellckeck a typo?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants